Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2575723002: DevTools: violation warnings pop up in sources while debugging (Closed)

Created:
4 years ago by pfeldman
Modified:
4 years ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: violation warnings pop up in sources while debugging BUG=673984 Committed: https://crrev.com/1a7c8ad0c25e9050ba74d00494590c35a8553735 Cr-Commit-Position: refs/heads/master@{#438415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pfeldman
4 years ago (2016-12-14 02:12:21 UTC) #2
kozy
lgtm
4 years ago (2016-12-14 02:12:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575723002/1
4 years ago (2016-12-14 02:14:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 03:37:01 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-14 03:38:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a7c8ad0c25e9050ba74d00494590c35a8553735
Cr-Commit-Position: refs/heads/master@{#438415}

Powered by Google App Engine
This is Rietveld 408576698