Move TraceInlinedFunction from Hydrogen graph builder to CompilationInfo.

Move TraceInlinedFunction from Hydrogen graph builder to internal::CodeGenerator.

This allows to share source dumping infrastructure between CS and TF and opens a possibility for external tools like IRHydra to perform deoptimization to source mapping for TF generated code based on --trace-deopt --print-opt-code --code-comments output.

This CL also restores an old TraceInlinedFunction behavior which was lost during source positions refactoring - originally TraceInlinedFunction dumped source code only once per-SFI to avoid large traces whenever some helper function is inlined multiple times.

This CL also adds --print-opt-source flag that would in the future replace obsolete --hydrogen-track-positions.

BUG=

Review-Url: https://codereview.chromium.org/2575703003
Cr-Commit-Position: refs/heads/master@{#41758}
Committed: https://chromium.googlesource.com/v8/v8/+/686d8c8685447c2b9e50b71106666b6d4e937871

[Vyacheslav Egorov (Google), 2016-12-14 15:48:02]

Description was changed from

==========
Move TraceInlinedFunction from Hydrogen graph builder to CompilationInfo.

This allows to share source dumping infrastructure between CS and TF and opens a
possibility for external tools like IRHydra to perform deoptimization to source
mapping for TF generated code based on --trace-deopt --print-opt-code
--code-comments output.

BUG=
==========

to

==========
Move TraceInlinedFunction from Hydrogen graph builder to CompilationInfo.

This allows to share source dumping infrastructure between CS and TF and opens a
possibility for external tools like IRHydra to perform deoptimization to source
mapping for TF generated code based on --trace-deopt --print-opt-code
--code-comments output.

This CL also restores an old TraceInlinedFunction behavior which was lost during
source positions refactoring - originally TraceInlinedFunction dumped source
code only once per-SFI to avoid large traces whenever some helper function is
inlined multiple times.

BUG=
==========

[Vyacheslav Egorov (Google), 2016-12-14 15:48:02]

vegorov@google.com changed reviewers:
+ bmeurer@chromium.org

[Vyacheslav Egorov (Google), 2016-12-14 15:48:12]

PTAL

[Benedikt Meurer, 2016-12-14 17:41:05]

bmeurer@chromium.org changed reviewers:
+ tebbi@chromium.org

[Benedikt Meurer, 2016-12-14 17:41:05]

bmeurer@chromium.org changed required reviewers:
+ tebbi@chromium.org

[Benedikt Meurer, 2016-12-14 17:41:06]

Tobias should review this, he did the source position support for TurboFan.

[Tobias Tebbi, 2016-12-15 16:22:01]

Thank you, IRHydra support for Turbofan would be awesome.

https://codereview.chromium.org/2575703003/diff/1/src/compilation-info.cc
File src/compilation-info.cc (right):

https://codereview.chromium.org/2575703003/diff/1/src/compilation-info.cc#new...
src/compilation-info.cc:222: *source_id = -1;
Is -1 here InlinedFunctionHolder::kSourceNotDumped? The semantics seem to not
quite fit the name, but then again, it's the same value...

https://codereview.chromium.org/2575703003/diff/1/src/compilation-info.h
File src/compilation-info.h (right):

https://codereview.chromium.org/2575703003/diff/1/src/compilation-info.h#newc...
src/compilation-info.h:287: int source_id;
These are too many ids. Now we have inlining_id, inlined_function_id and
source_id, all related to a single inlined function. Instead of adding state to
the compilation process, why not dump the inlined functions after the
compilation is complete, in internal::CodeGenerator. Also, CompilationInfo is
supposed to be a pure data container without logic.

https://codereview.chromium.org/2575703003/diff/1/src/compilation-info.h#newc...
src/compilation-info.h:347: // If we are tracking source positions then this
function prints a unique
"tracking source positions" is not an accurate description anymore. We track
source positions in many more circumstances than the --hydrogen-track-positions
flag. Perhaps we should introduce a new flag for IRHydra.

[Vyacheslav Egorov (Google), 2016-12-15 22:24:18]

Thanks for taking a look Tobias! Great idea about moving that to codegen. 

I think code became much cleaner with this move. 

Please take another look.

[Tobias Tebbi, 2016-12-16 11:52:29]

On 2016/12/15 22:24:18, Vyacheslav Egorov (Google) wrote:
> Thanks for taking a look Tobias! Great idea about moving that to codegen. 
> 
> I think code became much cleaner with this move. 
> 
> Please take another look.

Thanks! lgtm

[Vyacheslav Egorov (Google), 2016-12-16 12:25:15]

Description was changed from

==========
Move TraceInlinedFunction from Hydrogen graph builder to CompilationInfo.

This allows to share source dumping infrastructure between CS and TF and opens a
possibility for external tools like IRHydra to perform deoptimization to source
mapping for TF generated code based on --trace-deopt --print-opt-code
--code-comments output.

This CL also restores an old TraceInlinedFunction behavior which was lost during
source positions refactoring - originally TraceInlinedFunction dumped source
code only once per-SFI to avoid large traces whenever some helper function is
inlined multiple times.

BUG=
==========

to

==========
Move TraceInlinedFunction from Hydrogen graph builder to
internal::CodeGenerator.

This allows to share source dumping infrastructure between CS and TF and opens a
possibility for external tools like IRHydra to perform deoptimization to source
mapping for TF generated code based on --trace-deopt --print-opt-code
--code-comments output.

This CL also restores an old TraceInlinedFunction behavior which was lost during
source positions refactoring - originally TraceInlinedFunction dumped source
code only once per-SFI to avoid large traces whenever some helper function is
inlined multiple times.

This CL also adds --print-opt-source flag that would in the future replace
obsolete --hydrogen-track-positions.

BUG=
==========

[Vyacheslav Egorov (Google), 2016-12-16 12:25:44]

The CQ bit was checked by vegorov@google.com

[commit-bot: I haz the power, 2016-12-16 12:25:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 12:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 12:25:57]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Benedikt Meurer, 2016-12-16 12:27:52]

LGTM (rubber-stamped)

[Vyacheslav Egorov (Google), 2016-12-16 12:28:15]

The CQ bit was checked by vegorov@google.com

[commit-bot: I haz the power, 2016-12-16 12:28:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 12:57:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481891295879880,
"parent_rev": "3238b337c7b57cb8bf9da189e84ae5900f7b131a", "commit_rev":
"686d8c8685447c2b9e50b71106666b6d4e937871"}

[commit-bot: I haz the power, 2016-12-16 12:57:14]

Description was changed from

==========
Move TraceInlinedFunction from Hydrogen graph builder to
internal::CodeGenerator.

This allows to share source dumping infrastructure between CS and TF and opens a
possibility for external tools like IRHydra to perform deoptimization to source
mapping for TF generated code based on --trace-deopt --print-opt-code
--code-comments output.

This CL also restores an old TraceInlinedFunction behavior which was lost during
source positions refactoring - originally TraceInlinedFunction dumped source
code only once per-SFI to avoid large traces whenever some helper function is
inlined multiple times.

This CL also adds --print-opt-source flag that would in the future replace
obsolete --hydrogen-track-positions.

BUG=
==========

to

==========
Move TraceInlinedFunction from Hydrogen graph builder to
internal::CodeGenerator.

This allows to share source dumping infrastructure between CS and TF and opens a
possibility for external tools like IRHydra to perform deoptimization to source
mapping for TF generated code based on --trace-deopt --print-opt-code
--code-comments output.

This CL also restores an old TraceInlinedFunction behavior which was lost during
source positions refactoring - originally TraceInlinedFunction dumped source
code only once per-SFI to avoid large traces whenever some helper function is
inlined multiple times.

This CL also adds --print-opt-source flag that would in the future replace
obsolete --hydrogen-track-positions.

BUG=

Review-Url: https://codereview.chromium.org/2575703003
Cr-Commit-Position: refs/heads/master@{#41758}
Committed:
https://chromium.googlesource.com/v8/v8/+/686d8c8685447c2b9e50b71106666b6d4e9...
==========

[commit-bot: I haz the power, 2016-12-16 12:57:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/686d8c8685447c2b9e50b71106666b6d4e9...