Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2575683003: Fix SignWithOpenSSL in SSLPrivateKey tests. (Closed)

Created:
4 years ago by davidben
Modified:
4 years ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SignWithOpenSSL in SSLPrivateKey tests. EVP_PKEY operations are Windows-style with an in/out length parameter. It must be initialized to the size of the buffer. BUG=674179 Committed: https://crrev.com/eae1bf6b1e049585a95a449d98a77e7f187c6c83 Cr-Commit-Position: refs/heads/master@{#438554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/ssl/ssl_private_key_test_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
davidben
I'm surprised ASan didn't explode more dramatically.
4 years ago (2016-12-14 18:20:12 UTC) #3
Ryan Sleevi
Dang it :( Sorry for not catching this in review LGTM
4 years ago (2016-12-14 18:38:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575683003/1
4 years ago (2016-12-14 18:42:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 18:48:39 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-14 18:51:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eae1bf6b1e049585a95a449d98a77e7f187c6c83
Cr-Commit-Position: refs/heads/master@{#438554}

Powered by Google App Engine
This is Rietveld 408576698