Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2575673002: [CUPS] Add the missing library for the iron-dropdown. (Closed)

Created:
4 years ago by xdai1
Modified:
4 years ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Add the missing library for the iron-dropdown. BUG=673961 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/63293ca22a13dd82f1c3c75788b59c90aed92bcc Cr-Commit-Position: refs/heads/master@{#438647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
xdai1
michalepg@, could you help review this CL please? Thanks!
4 years ago (2016-12-14 00:48:25 UTC) #3
michaelpg
lgtm
4 years ago (2016-12-14 20:20:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575673002/1
4 years ago (2016-12-14 20:49:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 22:10:11 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-14 22:12:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63293ca22a13dd82f1c3c75788b59c90aed92bcc
Cr-Commit-Position: refs/heads/master@{#438647}

Powered by Google App Engine
This is Rietveld 408576698