ios/chrome/browser/interstitials/ios_chrome_metrics_helper.mm - Issue 2575623002: Componentizing SafeBrowsingBlockingPage Part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/interstitials/ios_chrome_metrics_helper.mm

Issue 2575623002: Componentizing SafeBrowsingBlockingPage Part 1 (Closed)

Patch Set: address comments from nparker@ Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/interstitials/ios_chrome_metrics_helper.mm

diff --git a/ios/chrome/browser/interstitials/ios_chrome_metrics_helper.mm b/ios/chrome/browser/interstitials/ios_chrome_metrics_helper.mm

index f1fa47ed0bd2ed6d596b38f4dd013788ca34aa7d..93e14db2f6341807628a14f6abcb99a72cb55cfd 100644

--- a/ios/chrome/browser/interstitials/ios_chrome_metrics_helper.mm

+++ b/ios/chrome/browser/interstitials/ios_chrome_metrics_helper.mm

@@ -26,10 +26,7 @@ IOSChromeMetricsHelper::IOSChromeMetricsHelper(

ios::HistoryServiceFactory::GetForBrowserState(

ios::ChromeBrowserState::FromBrowserState(

web_state->GetBrowserState()),

- ServiceAccessType::EXPLICIT_ACCESS),

- GetApplicationContext()->GetRapporServiceImpl()

- ? GetApplicationContext()->GetRapporServiceImpl()->AsWeakPtr()

- : base::WeakPtr<rappor::RapporService>()) {}

+ ServiceAccessType::EXPLICIT_ACCESS)) {}

IOSChromeMetricsHelper::~IOSChromeMetricsHelper() {}