ios/chrome/browser/interstitials/ios_chrome_controller_client.mm - Issue 2575623002: Componentizing SafeBrowsingBlockingPage Part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

Issue 2575623002: Componentizing SafeBrowsingBlockingPage Part 1 (Closed)

Patch Set: address comments from nparker@ Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

diff --git a/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm b/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

index 6b5c5c67dd2f6ac576b6c984e1f3b2f5bce2bf9a..1f5b8b2452a8ee1a973bdf68d69f896ac4f28311 100644

--- a/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

+++ b/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

@@ -44,6 +44,10 @@ void IOSChromeControllerClient::GoBack() {

web_interstitial_->DontProceed();

}

+void IOSChromeControllerClient::GoBackAfterNavigationCommitted() {

+ NOTREACHED();

void IOSChromeControllerClient::Proceed() {

DCHECK(web_interstitial_);

web_interstitial_->Proceed();