Add data usage tracking for GAIA auth api

Add data usage tracking for GAIA auth api

BUG=655749
Review-Url: https://codereview.chromium.org/2575603002
Cr-Commit-Position: refs/heads/master@{#445626}
Committed: https://chromium.googlesource.com/chromium/src/+/a66ce0054bc03e4a8e787871bdf29a38e3e528d3

[Raj, 2016-12-13 21:52:28]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 21:52:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raj, 2016-12-13 21:59:10]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 21:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raj, 2016-12-13 22:00:30]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 22:00:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:21:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 23:21:13]

Dry run: This issue passed the CQ dry run.

[Raj, 2016-12-14 06:08:58]

Description was changed from

==========
temp

BUG=
==========

to

==========
Add data usage tracking for GAIA auth api

BUG=655749
==========

[Raj, 2016-12-14 06:10:55]

rajendrant@chromium.org changed reviewers:
+ zelidrag@chromium.org

[Raj, 2016-12-14 06:10:56]

zelidrag: ptal  google_apis/gaia/*

[Raj, 2016-12-14 06:12:04]

On 2016/12/14 06:10:56, Raj wrote:
> zelidrag: ptal  google_apis/gaia/*

This is a modified approach since src/google_apis does not want to depend on
components/data_use_measurement in below CL.
https://codereview.chromium.org/2486423002/

[Raj, 2016-12-29 18:15:32]

On 2016/12/14 06:12:04, Raj wrote:
> On 2016/12/14 06:10:56, Raj wrote:
> > zelidrag: ptal  google_apis/gaia/*
> 
> This is a modified approach since src/google_apis does not want to depend on
> components/data_use_measurement in below CL.
> https://codereview.chromium.org/2486423002/

zelidrag: friendly ping. ptal

[Raj, 2017-01-12 03:25:34]

On 2016/12/29 18:15:32, Raj wrote:
> On 2016/12/14 06:12:04, Raj wrote:
> > On 2016/12/14 06:10:56, Raj wrote:
> > > zelidrag: ptal  google_apis/gaia/*
> > 
> > This is a modified approach since src/google_apis does not want to depend on
> > components/data_use_measurement in below CL.
> > https://codereview.chromium.org/2486423002/
> 
> zelidrag: friendly ping. ptal

zelidrag: friendly ping. ptal

[Raj, 2017-01-20 21:49:29]

rajendrant@chromium.org changed reviewers:
+ msarda@chromium.org

[Raj, 2017-01-20 21:49:29]

msarda: ptal google_apis/gaia/*

[msarda, 2017-01-23 09:29:29]

LGTM with nits.

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_a...
File google_apis/gaia/gaia_auth_util.cc (right):

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:28: const void* kURLRequestUserDataKey =
&kURLRequestUserDataKey;
This is the first time I see this kind of definition, so please ignore me if
this comment is not needed:
I see in other places, that folks are using a static_cast<const void*> for this
definitions (is that really needed?):
const void* kURLRequestUserDataKey =
    static_cast<const void*>(&kURLRequestUserDataKey);

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:198: void
MarkURLFetcherAsGaia(net::URLFetcher* fetcher) {
DCHECK(fetcher);

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:199:
fetcher->SetURLRequestUserData(&kURLRequestUserDataKey,
Remove the "&"

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_o...
File google_apis/gaia/gaia_oauth_client.cc (right):

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_o...
google_apis/gaia/gaia_oauth_client.cc:187: MarkURLFetcherAsGaia(&*request_);
Here are below: I think I would prefer request.get() instead of &*request

[Raj, 2017-01-23 18:36:57]

Patchset #3 (id:40001) has been deleted

[Raj, 2017-01-23 18:47:10]

rajendrant@chromium.org changed reviewers:
+ holte@chromium.org, tbansal@chromium.org
- zelidrag@chromium.org

[Raj, 2017-01-23 18:47:11]

msarda: ptal new changes in google_apis/gaia/*

holte: ptal histograms.xml

tbansal: ptal components/data_use_measurement/core/*

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_a...
File google_apis/gaia/gaia_auth_util.cc (right):

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:28: const void* kURLRequestUserDataKey =
&kURLRequestUserDataKey;
On 2017/01/23 09:29:28, msarda wrote:
> This is the first time I see this kind of definition, so please ignore me if
> this comment is not needed:
> I see in other places, that folks are using a static_cast<const void*> for
this
> definitions (is that really needed?):
> const void* kURLRequestUserDataKey =
>     static_cast<const void*>(&kURLRequestUserDataKey);

Done.

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:198: void
MarkURLFetcherAsGaia(net::URLFetcher* fetcher) {
On 2017/01/23 09:29:28, msarda wrote:
> DCHECK(fetcher);

Done.

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:199:
fetcher->SetURLRequestUserData(&kURLRequestUserDataKey,
On 2017/01/23 09:29:28, msarda wrote:
> Remove the "&"

Done.

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:199:
fetcher->SetURLRequestUserData(&kURLRequestUserDataKey,
On 2017/01/23 09:29:28, msarda wrote:
> Remove the "&"

Done.

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_o...
File google_apis/gaia/gaia_oauth_client.cc (right):

https://codereview.chromium.org/2575603002/diff/20001/google_apis/gaia/gaia_o...
google_apis/gaia/gaia_oauth_client.cc:187: MarkURLFetcherAsGaia(&*request_);
On 2017/01/23 09:29:29, msarda wrote:
> Here are below: I think I would prefer request.get() instead of &*request

Done.

[tbansal1, 2017-01-23 21:03:05]

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
File google_apis/gaia/gaia_auth_util.cc (right):

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:55: return new GaiaURLRequestUserData();
qq, who frees up this data? (I do not know enough about SupportsUserData).

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:202:
base::Bind(&GaiaURLRequestUserData::Create));
#include "base/bind.h"

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
File google_apis/gaia/gaia_auth_util.h (right):

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.h:16: class URLFetcher;
nit: Alphabetical order.

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.h:17: };
// namespace net
Also rm semicolon

[Raj, 2017-01-23 21:53:02]

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
File google_apis/gaia/gaia_auth_util.cc (right):

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:55: return new GaiaURLRequestUserData();
On 2017/01/23 21:03:05, tbansal1 wrote:
> qq, who frees up this data? (I do not know enough about SupportsUserData).

It will be owned by SupportsUserData and freed in its destructor.

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.cc:202:
base::Bind(&GaiaURLRequestUserData::Create));
On 2017/01/23 21:03:05, tbansal1 wrote:
> #include "base/bind.h"

Done.

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
File google_apis/gaia/gaia_auth_util.h (right):

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.h:16: class URLFetcher;
On 2017/01/23 21:03:05, tbansal1 wrote:
> nit: Alphabetical order.

Done.

https://codereview.chromium.org/2575603002/diff/60001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_util.h:17: };
On 2017/01/23 21:03:05, tbansal1 wrote:
> // namespace net
> Also rm semicolon

Done.

[Steven Holte, 2017-01-24 01:43:05]

histograms lgtm

[Raj, 2017-01-24 01:51:25]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 01:52:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-01-24 02:33:43]

lgtm

[Raj, 2017-01-24 02:46:08]

The CQ bit was unchecked by rajendrant@chromium.org

[Raj, 2017-01-24 02:46:09]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2017-01-24 02:46:09]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2575603002/#ps80001
(title: "Addressed tbansal comments")

[commit-bot: I haz the power, 2017-01-24 02:46:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 03:23:14]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485225969341690,
"parent_rev": "5b4340f5cc4ce700b3e67ef61e5c351766d94b83", "commit_rev":
"a66ce0054bc03e4a8e787871bdf29a38e3e528d3"}

[commit-bot: I haz the power, 2017-01-24 03:23:49]

Description was changed from

==========
Add data usage tracking for GAIA auth api

BUG=655749
==========

to

==========
Add data usage tracking for GAIA auth api

BUG=655749

Review-Url: https://codereview.chromium.org/2575603002
Cr-Commit-Position: refs/heads/master@{#445626}
Committed:
https://chromium.googlesource.com/chromium/src/+/a66ce0054bc03e4a8e787871bdf2...
==========

[commit-bot: I haz the power, 2017-01-24 03:23:50]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a66ce0054bc03e4a8e787871bdf2...