Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2575583002: Remove ClipPathDisplayItem::clip_op_ (Closed)

Created:
4 years ago by f(malita)
Modified:
4 years ago
Reviewers:
chrishtr, reed1
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbauman+watch_chromium.org, jbroman, Justin Novosad, kalyank, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ClipPathDisplayItem::clip_op_ We only use kIntersect in practice, no need to paramaterize. R=reed@google.com,chrishtr@chromium.org TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/fabe7b9efe934b2aa3487771f8aa72be49e18850 Cr-Commit-Position: refs/heads/master@{#438556}

Patch Set 1 #

Patch Set 2 : remove SkClipOp conversion utils #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -63 lines) Patch
M cc/blink/web_display_item_list_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/blink/web_display_item_list_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/playback/clip_path_display_item.h View 3 chunks +2 lines, -4 lines 0 comments Download
M cc/playback/clip_path_display_item.cc View 5 chunks +3 lines, -8 lines 0 comments Download
M cc/playback/display_item_list_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M cc/proto/skia_conversions.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M cc/proto/skia_conversions.cc View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M cc/proto/skia_conversions_unittest.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebDisplayItemList.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/compositor/clip_recorder.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (21 generated)
f(malita)
This will need to be rebased after Mike's https://codereview.chromium.org/2572833002/, but otherwise ready for review.
4 years ago (2016-12-13 21:50:50 UTC) #7
chrishtr
lgtm
4 years ago (2016-12-13 21:53:47 UTC) #8
reed1
lgtm
4 years ago (2016-12-13 22:13:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575583002/40001
4 years ago (2016-12-14 14:34:02 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/325811)
4 years ago (2016-12-14 14:40:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575583002/40001
4 years ago (2016-12-14 15:49:38 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/325864)
4 years ago (2016-12-14 15:57:26 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575583002/40001
4 years ago (2016-12-14 17:57:01 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-14 18:51:22 UTC) #29
commit-bot: I haz the power
4 years ago (2016-12-14 18:54:17 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fabe7b9efe934b2aa3487771f8aa72be49e18850
Cr-Commit-Position: refs/heads/master@{#438556}

Powered by Google App Engine
This is Rietveld 408576698