Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2575533002: SkClipOp is an enum class now (Closed)

Created:
4 years ago by reed1
Modified:
4 years ago
Reviewers:
f(malita)
CC:
chromium-reviews, sadrul, blink-reviews-platform-graphics_chromium.org, dshwang, dcheng, rsesek+watch_chromium.org, Stephen Chennney, miu+watch_chromium.org, krit, drott+blinkwatch_chromium.org, jam, Justin Novosad, bruthig+ink_drop_chromium.org, jbauman+watch_chromium.org, Rik, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, kalyank, rwlbuis, ajuma+watch_chromium.org, mlamouri+watch-content_chromium.org, msw+watch_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, hcarmona+bubble_chromium.org, haraken, piman+watch_chromium.org, danakj+watch_chromium.org, rouslan+bubble_chromium.org, groby+bubble_chromium.org, ajuma+watch-canvas_chromium.org, tfarina, Ian Vollick, f(malita), cc-bugs_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SkClipOp is an enum class now purely a renaming from Foo_SkClipOp to SkClipOp::Foo plus one static_cast to treat the enum as an index into array. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR= Committed: https://crrev.com/479f44fcb9fc0e11729a425f0c6ef00642d272c4 Cr-Commit-Position: refs/heads/master@{#438195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -62 lines) Patch
M ash/common/system/tray/tray_details_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/display_item_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/raster_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/proto/skia_conversions.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M cc/proto/skia_conversions_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/windows_10_caption_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/color_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/ext/benchmarking_canvas.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/ClipList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/clip_recorder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/ink_drop_painted_layer_delegates.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/bubble/bubble_border.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
reed1
4 years ago (2016-12-13 14:50:30 UTC) #4
f(malita)
Description nit: s/a real enum/an enum class/ LGTM
4 years ago (2016-12-13 14:58:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575533002/1
4 years ago (2016-12-13 14:59:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 17:04:39 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-13 17:07:29 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/479f44fcb9fc0e11729a425f0c6ef00642d272c4
Cr-Commit-Position: refs/heads/master@{#438195}

Powered by Google App Engine
This is Rietveld 408576698