Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2575513002: Actually disable load:tools:gmail (Closed)

Created:
4 years ago by hjd
Modified:
4 years ago
Reviewers:
perezju, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Actually disable load:tools:gmail The decorator was applied to a base class which doesn't actually cause anything to be disabled. BUG=catapult#:3088 Committed: https://crrev.com/2e324fe89c41674a938475ca37edacca23f83f7f Cr-Commit-Position: refs/heads/master@{#438149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/page_sets/system_health/loading_stories.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
hjd
ptal, thanks!
4 years ago (2016-12-13 11:42:43 UTC) #4
perezju
lgtm, but I think you also need Ned's stamp.
4 years ago (2016-12-13 11:45:04 UTC) #5
nednguyen
lgtm
4 years ago (2016-12-13 12:20:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575513002/1
4 years ago (2016-12-13 12:20:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 13:11:31 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-13 13:13:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e324fe89c41674a938475ca37edacca23f83f7f
Cr-Commit-Position: refs/heads/master@{#438149}

Powered by Google App Engine
This is Rietveld 408576698