[interpreter][stubs] Enable graph verification for bytecode handlers and stubs included into snapsh…

[interpreter][stubs] Enable graph verification for bytecode handlers and stubs included into snapshot.

BUG=

Committed: https://crrev.com/b5a9381a5652bb2200bb9c1125b6cbd21bf4b362
Cr-Commit-Position: refs/heads/master@{#41676}

[Igor Sheludko, 2016-12-13 10:19:33]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-12-13 10:27:35]

Patchset #2 (id:40001) has been deleted

[Igor Sheludko, 2016-12-13 10:27:41]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 10:27:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-12-13 10:28:29]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2016-12-13 10:28:29]

PTAL and CQ

[Igor Sheludko, 2016-12-13 10:28:35]

The CQ bit was unchecked by ishell@chromium.org

[Michael Starzinger, 2016-12-13 12:54:06]

https://codereview.chromium.org/2575473002/diff/20001/src/compilation-info.h
File src/compilation-info.h (right):

https://codereview.chromium.org/2575473002/diff/20001/src/compilation-info.h#...
src/compilation-info.h:391: bool verify_graph_;
Please move this field into {compiler::PipelineData} instead. It is specific to
TruboFan and not needed for other compilers.

[Igor Sheludko, 2016-12-13 13:23:36]

https://codereview.chromium.org/2575473002/diff/20001/src/compilation-info.h
File src/compilation-info.h (right):

https://codereview.chromium.org/2575473002/diff/20001/src/compilation-info.h#...
src/compilation-info.h:391: bool verify_graph_;
On 2016/12/13 12:54:06, Michael Starzinger wrote:
> Please move this field into {compiler::PipelineData} instead. It is specific
to
> TruboFan and not needed for other compilers.

Done.

[Igor Sheludko, 2016-12-13 13:27:38]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 13:27:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-12-13 13:32:35]

LGTM. Thanks!

[Igor Sheludko, 2016-12-13 13:32:59]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-12-13 13:33:03]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-12-13 13:33:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 13:55:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481635983225120,
"parent_rev": "7a55ed6e23fb9991d6b799f81bad8d9fe9e52c3d", "commit_rev":
"165d331f47b778f10e06e8666af267313da20d9a"}

[commit-bot: I haz the power, 2016-12-13 13:55:10]

Description was changed from

==========
[interpreter][stubs] Enable graph verification for bytecode handlers and stubs
included into snapshot.

BUG=
==========

to

==========
[interpreter][stubs] Enable graph verification for bytecode handlers and stubs
included into snapshot.

BUG=

Review-Url: https://codereview.chromium.org/2575473002
==========

[commit-bot: I haz the power, 2016-12-13 13:55:11]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-12-13 13:55:36]

Description was changed from

==========
[interpreter][stubs] Enable graph verification for bytecode handlers and stubs
included into snapshot.

BUG=

Review-Url: https://codereview.chromium.org/2575473002
==========

to

==========
[interpreter][stubs] Enable graph verification for bytecode handlers and stubs
included into snapshot.

BUG=

Committed: https://crrev.com/b5a9381a5652bb2200bb9c1125b6cbd21bf4b362
Cr-Commit-Position: refs/heads/master@{#41676}
==========

[commit-bot: I haz the power, 2016-12-13 13:55:37]

Patchset 2 (id:??) landed as
https://crrev.com/b5a9381a5652bb2200bb9c1125b6cbd21bf4b362
Cr-Commit-Position: refs/heads/master@{#41676}