Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2575453002:
Revert of Disable flaky test (Closed)
DescriptionRevert of Disable flaky test (patchset #2 id:20001 of https://codereview.chromium.org/2564213002/ )
Reason for revert:
Test is no longer flaky.
Original issue's description:
> Disable flaky test
>
> ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was
> detected to be flaky by chromium-try-flakes.
>
> TBR=lizeb@chromium.org
>
> BUG=673028
>
> Committed: https://crrev.com/8ae700640b7237af3acc10025827497be8376aab
> Cr-Commit-Position: refs/heads/master@{#437907}
TBR=asargent@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673028
Committed: https://crrev.com/ab182621e72a32aeb610b6368cda75ba63a9a6d1
Cr-Commit-Position: refs/heads/master@{#438097}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by alexilin@chromium.org
Created Revert of Disable flaky test
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
alexilin@chromium.org changed reviewers: + lizeb@chromium.org - asargent@chromium.org
Hi Benoit, The browser test for ResourcePrefetchPredictor was disabled due to flakiness. We've already fixed this problem so we can revert disabling.
The CQ bit was checked by alexilin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/12/13 07:51:59, alexilin wrote: > Hi Benoit, > > The browser test for ResourcePrefetchPredictor was disabled due to flakiness. > We've already fixed this problem so we can revert disabling. lgtm
The CQ bit was checked by alexilin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481616992948710, "parent_rev":
"bfd96192855fb0852464c468142f2687ff3ed236", "commit_rev":
"4ceac4896ce4db5e7c7b6713eeddc18c9ff3c19a"}
Message was sent while issue was closed.
Description was changed from ========== Revert of Disable flaky test (patchset #2 id:20001 of https://codereview.chromium.org/2564213002/ ) Reason for revert: Test is no longer flaky. Original issue's description: > Disable flaky test > > ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was > detected to be flaky by chromium-try-flakes. > > TBR=lizeb@chromium.org > > BUG=673028 > > Committed: https://crrev.com/8ae700640b7237af3acc10025827497be8376aab > Cr-Commit-Position: refs/heads/master@{#437907} TBR=asargent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673028 ========== to ========== Revert of Disable flaky test (patchset #2 id:20001 of https://codereview.chromium.org/2564213002/ ) Reason for revert: Test is no longer flaky. Original issue's description: > Disable flaky test > > ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was > detected to be flaky by chromium-try-flakes. > > TBR=lizeb@chromium.org > > BUG=673028 > > Committed: https://crrev.com/8ae700640b7237af3acc10025827497be8376aab > Cr-Commit-Position: refs/heads/master@{#437907} TBR=asargent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673028 Review-Url: https://codereview.chromium.org/2575453002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Disable flaky test (patchset #2 id:20001 of https://codereview.chromium.org/2564213002/ ) Reason for revert: Test is no longer flaky. Original issue's description: > Disable flaky test > > ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was > detected to be flaky by chromium-try-flakes. > > TBR=lizeb@chromium.org > > BUG=673028 > > Committed: https://crrev.com/8ae700640b7237af3acc10025827497be8376aab > Cr-Commit-Position: refs/heads/master@{#437907} TBR=asargent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673028 Review-Url: https://codereview.chromium.org/2575453002 ========== to ========== Revert of Disable flaky test (patchset #2 id:20001 of https://codereview.chromium.org/2564213002/ ) Reason for revert: Test is no longer flaky. Original issue's description: > Disable flaky test > > ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was > detected to be flaky by chromium-try-flakes. > > TBR=lizeb@chromium.org > > BUG=673028 > > Committed: https://crrev.com/8ae700640b7237af3acc10025827497be8376aab > Cr-Commit-Position: refs/heads/master@{#437907} TBR=asargent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673028 Committed: https://crrev.com/ab182621e72a32aeb610b6368cda75ba63a9a6d1 Cr-Commit-Position: refs/heads/master@{#438097} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ab182621e72a32aeb610b6368cda75ba63a9a6d1 Cr-Commit-Position: refs/heads/master@{#438097} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
