Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2575433002: Roll third_party/icu from 73e24736 to 9cd28287 (Closed)

Created:
4 years ago by tsniatowski
Modified:
4 years ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll third_party/icu from 73e24736 to 9cd28287 http://chromium.googlesource.com/chromium/deps/icu.git/+log/73e24736..9cd28287 One change in the range: deprecation warning suppresion for non-clang. BUG=21515, 637001 Committed: https://crrev.com/a26ef00baeed7f52c1903c3645218b06b429e769 Cr-Commit-Position: refs/heads/master@{#438139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
tsniatowski
PTAL (note: local presubmit failed for me like in https://bugs.chromium.org/p/chromium/issues/detail?id=672933 but seems to have passed ...
4 years ago (2016-12-13 07:38:32 UTC) #5
Nico
lgtm
4 years ago (2016-12-13 12:06:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575433002/1
4 years ago (2016-12-13 12:06:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 12:11:38 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 12:15:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a26ef00baeed7f52c1903c3645218b06b429e769
Cr-Commit-Position: refs/heads/master@{#438139}

Powered by Google App Engine
This is Rietveld 408576698