Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2575423002: CSS Animations: Reformat animation-transition-collision-crash.html (Closed)

Created:
4 years ago by Eric Willigers
Modified:
4 years ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Animations: Reformat animation-transition-collision-crash.html Update test to follow style guide https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_layout_tests.md Stop marking the test as flaky, as no recent flakes have been observed. BUG=664857 Committed: https://crrev.com/ddbfebc9e931593ff6ef86cd1da3bbbdad3f5a3e Cr-Commit-Position: refs/heads/master@{#440350}

Patch Set 1 #

Patch Set 2 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/animations/animation-transition-collision-crash.html View 1 2 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Eric Willigers
4 years ago (2016-12-15 09:04:41 UTC) #6
alancutter (OOO until 2018)
What part of this change causes the test to no longer be flaky?
4 years ago (2016-12-16 00:38:05 UTC) #7
alancutter (OOO until 2018)
On 2016/12/15 at 09:04:41, ericwilligers wrote: > How does this change fix the flake?
4 years ago (2016-12-16 07:06:44 UTC) #8
Eric Willigers
On 2016/12/16 07:06:44, alancutter wrote: > On 2016/12/15 at 09:04:41, ericwilligers wrote: > > > ...
4 years ago (2016-12-20 23:54:12 UTC) #10
alancutter (OOO until 2018)
lgtm
4 years ago (2016-12-22 05:54:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575423002/20001
4 years ago (2016-12-22 06:11:02 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-22 07:21:17 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-22 07:23:08 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ddbfebc9e931593ff6ef86cd1da3bbbdad3f5a3e
Cr-Commit-Position: refs/heads/master@{#440350}

Powered by Google App Engine
This is Rietveld 408576698