Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2575413003: DevTools: Animations: Remember the playback rate (Closed)

Created:
4 years ago by einbinder
Modified:
4 years ago
Reviewers:
dgozman
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, pfeldman+blink_chromium.org, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Animations: Remember the playback rate BUG=674322 Committed: https://crrev.com/fbf29d84762c94c99de08407207f53305bdbb5f5 Cr-Commit-Position: refs/heads/master@{#439298}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't use setting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
einbinder
ptal
4 years ago (2016-12-16 01:47:27 UTC) #2
dgozman
https://codereview.chromium.org/2575413003/diff/1/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js File third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js (right): https://codereview.chromium.org/2575413003/diff/1/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js#newcode330 third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js:330: this._setPlaybackRate(this._playbackRateSetting.get()); Setting is used to persist between DevTools reopening, ...
4 years ago (2016-12-16 05:44:31 UTC) #3
einbinder
https://codereview.chromium.org/2575413003/diff/1/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js File third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js (right): https://codereview.chromium.org/2575413003/diff/1/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js#newcode330 third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js:330: this._setPlaybackRate(this._playbackRateSetting.get()); On 2016/12/16 at 05:44:31, dgozman wrote: > Setting ...
4 years ago (2016-12-16 22:37:05 UTC) #4
dgozman
lgtm
4 years ago (2016-12-16 23:56:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575413003/20001
4 years ago (2016-12-17 00:16:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-17 02:42:46 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-17 02:45:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbf29d84762c94c99de08407207f53305bdbb5f5
Cr-Commit-Position: refs/heads/master@{#439298}

Powered by Google App Engine
This is Rietveld 408576698