DevTools: Animations: Remember the playback rate

DevTools: Animations: Remember the playback rate

BUG=674322
Committed: https://crrev.com/fbf29d84762c94c99de08407207f53305bdbb5f5
Cr-Commit-Position: refs/heads/master@{#439298}

[einbinder, 2016-12-16 01:47:26]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2016-12-16 01:47:27]

ptal

[dgozman, 2016-12-16 05:44:31]

https://codereview.chromium.org/2575413003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
(right):

https://codereview.chromium.org/2575413003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js:330:
this._setPlaybackRate(this._playbackRateSetting.get());
Setting is used to persist between DevTools reopening, which is not the case
here.

Looks like just passing this._playbackRate instead of 1 here fixes the problem?

[einbinder, 2016-12-16 22:37:05]

https://codereview.chromium.org/2575413003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
(right):

https://codereview.chromium.org/2575413003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js:330:
this._setPlaybackRate(this._playbackRateSetting.get());
On 2016/12/16 at 05:44:31, dgozman wrote:
> Setting is used to persist between DevTools reopening, which is not the case
here.
> 
> Looks like just passing this._playbackRate instead of 1 here fixes the
problem?

I thought we wanted it to persist between devtools sessions. Changed.

[dgozman, 2016-12-16 23:56:07]

lgtm

[einbinder, 2016-12-17 00:15:26]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2016-12-17 00:16:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 02:42:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481933726648180,
"parent_rev": "4150b0dc1e6e2305690bc83dfffda9cc0f7e6577", "commit_rev":
"b50d4f13507cd79b0f96198da23fce753901b1de"}

[commit-bot: I haz the power, 2016-12-17 02:42:45]

Description was changed from

==========
DevTools: Animations: Remember the playback rate

BUG=674322
==========

to

==========
DevTools: Animations: Remember the playback rate

BUG=674322

Review-Url: https://codereview.chromium.org/2575413003
==========

[commit-bot: I haz the power, 2016-12-17 02:42:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-17 02:45:38]

Description was changed from

==========
DevTools: Animations: Remember the playback rate

BUG=674322

Review-Url: https://codereview.chromium.org/2575413003
==========

to

==========
DevTools: Animations: Remember the playback rate

BUG=674322

Committed: https://crrev.com/fbf29d84762c94c99de08407207f53305bdbb5f5
Cr-Commit-Position: refs/heads/master@{#439298}
==========

[commit-bot: I haz the power, 2016-12-17 02:45:40]

Patchset 2 (id:??) landed as
https://crrev.com/fbf29d84762c94c99de08407207f53305bdbb5f5
Cr-Commit-Position: refs/heads/master@{#439298}