Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 25754002: Move makeSpace and resetToSize from SkPathRef.cpp to .h (Closed)

Created:
7 years, 2 months ago by robertphillips
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Together with r11575 (Make it explicit that some validate methods are debug only - https://codereview.chromium.org/25716003/), this CL fixes the performance regression (crbug.com/302570) caused by r11506 (Move unlikely-to-be-inlined code from SkPathRef.h to SkPathRef.cpp - https://codereview.chromium.org/24998004/)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -65 lines) Patch
M include/core/SkPathRef.h View 2 chunks +60 lines, -2 lines 0 comments Download
M src/core/SkPathRef.cpp View 2 chunks +0 lines, -63 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
7 years, 2 months ago (2013-10-02 16:52:53 UTC) #1
bsalomon
On 2013/10/02 16:52:53, robertphillips wrote: lgtm
7 years, 2 months ago (2013-10-02 17:44:28 UTC) #2
robertphillips
7 years, 2 months ago (2013-10-02 17:50:06 UTC) #3
Message was sent while issue was closed.
committed as r11578

Powered by Google App Engine
This is Rietveld 408576698