[Complier] Only optimize a function marked for tier-up if it is compiled.

[Complier] Only optimize a function marked for tier-up if it is compiled.

When mark-shared-funtion-for-tier-up is enabled, a function could be marked for
optimization, then the baseline (FCG) code is flushed by the GC. The next time
the function is executed, we shouldn't optimize the code if there isn't
baseline code.

BUG=chromium:673242
Review-Url: https://codereview.chromium.org/2575333003
Cr-Commit-Position: refs/heads/master@{#41751}
Committed: https://chromium.googlesource.com/v8/v8/+/cb9d0fe7f4789dc5c471fcb092457efc503bd2e4

[rmcilroy, 2016-12-15 16:18:47]

rmcilroy@chromium.org changed reviewers:
+ leszeks@chromium.org, mstarzinger@chromium.org

[rmcilroy, 2016-12-15 16:18:47]

Michi / Leszek PTAL.

[rmcilroy, 2016-12-15 16:18:50]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 16:18:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Leszek Swirski, 2016-12-15 16:25:55]

I'm a bit confused by this patch, doesn't it mean that never compiled functions
are never given a chance to tier up?

[rmcilroy, 2016-12-15 16:31:40]

On 2016/12/15 16:25:55, Leszek Swirski wrote:
> I'm a bit confused by this patch, doesn't it mean that never compiled
functions
> are never given a chance to tier up?

If the function wasn't compiled it shouldn't be marked to be optimized (since
it's never been run). This only triggers an issue when code-flushing comes in
and a function which was marked to be optimized has the code flushed from it
before being optimized, and when we run it again we try to optimize the function
which has no baseline code.

[commit-bot: I haz the power, 2016-12-15 16:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 16:47:33]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-12-16 10:36:36]

LGTM.

[rmcilroy, 2016-12-16 10:41:58]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-12-16 10:42:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 10:44:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481884918522760, "parent_rev":
"d4a7c4bf66aa54187f3b4a554fd5fe0caa744ce4", "commit_rev":
"cb9d0fe7f4789dc5c471fcb092457efc503bd2e4"}

[commit-bot: I haz the power, 2016-12-16 10:44:57]

Description was changed from

==========
[Complier] Only optimize a function marked for tier-up if it is compiled.

When mark-shared-funtion-for-tier-up is enabled, a function could be marked for
optimization, then the baseline (FCG) code is flushed by the GC. The next time
the function is executed, we shouldn't optimize the code if there isn't
baseline code.

BUG=chromium:673242
==========

to

==========
[Complier] Only optimize a function marked for tier-up if it is compiled.

When mark-shared-funtion-for-tier-up is enabled, a function could be marked for
optimization, then the baseline (FCG) code is flushed by the GC. The next time
the function is executed, we shouldn't optimize the code if there isn't
baseline code.

BUG=chromium:673242

Review-Url: https://codereview.chromium.org/2575333003
Cr-Commit-Position: refs/heads/master@{#41751}
Committed:
https://chromium.googlesource.com/v8/v8/+/cb9d0fe7f4789dc5c471fcb092457efc503...
==========

[commit-bot: I haz the power, 2016-12-16 10:44:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cb9d0fe7f4789dc5c471fcb092457efc503...