Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2575293002: Merge RandomOrderExpectations into TestExpectations (Closed)

Created:
4 years ago by jeffcarp
Modified:
4 years ago
Reviewers:
Dirk Pranke, qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge RandomOrderExpectations into TestExpectations Mark tests with pre-existing lines above as possible duplicates. Will follow up on each of those. BUG=674313 Committed: https://crrev.com/8e38a374d43495ce0232f214febecceb7353e412 Cr-Commit-Position: refs/heads/master@{#438974}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase, address CL feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -161 lines) Patch
D third_party/WebKit/LayoutTests/RandomOrderExpectations View 1 chunk +0 lines, -161 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +174 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jeffcarp
4 years ago (2016-12-15 00:45:51 UTC) #2
qyearsley
LGTM with nits https://codereview.chromium.org/2575293002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2575293002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode2305 third_party/WebKit/LayoutTests/TestExpectations:2305: # ====== Random order flaky tests ...
4 years ago (2016-12-15 22:17:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575293002/20001
4 years ago (2016-12-15 23:26:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 01:13:34 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-16 01:17:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e38a374d43495ce0232f214febecceb7353e412
Cr-Commit-Position: refs/heads/master@{#438974}

Powered by Google App Engine
This is Rietveld 408576698