Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 2575253002: Fix Excessive test output. (Closed)

Created:
4 years ago by stevenjb
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix Excessive test output. After http://crrev.com/2406243004, any test that produces more than 32Kb will be failed. With improved error messages and timeouts added on the test, we no longer need to print out the current test that we are running. This CL reduces the output of QUnitBrowserTests from ~ 2MB to 29KB. BUG=670759 Review-Url: https://codereview.chromium.org/2569373002 Cr-Commit-Position: refs/heads/master@{#438354} (cherry picked from commit 5411331a2c4bef3cf2dd078b0a4a675b73362828) Committed: https://chromium.googlesource.com/chromium/src/+/da057f55703c2b846a580c420b73bf26d336dcae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M third_party/qunit/src/browser_test_harness.js View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
stevenjb
4 years ago (2016-12-14 23:53:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da057f55703c2b846a580c420b73bf26d336dcae.

Powered by Google App Engine
This is Rietveld 408576698