Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2569373002: Fix Excessive test output. (Closed)

Created:
4 years ago by kelvinp
Modified:
4 years ago
Reviewers:
Jamie
CC:
chromium-reviews, Paweł Hajdan Jr., stevenjb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Excessive test output. After http://crrev.com/2406243004, any test that produces more than 32Kb will be failed. With improved error messages and timeouts added on the test, we no longer need to print out the current test that we are running. This CL reduces the output of QUnitBrowserTests from ~ 2MB to 29KB. BUG=670759 Committed: https://crrev.com/5411331a2c4bef3cf2dd078b0a4a675b73362828 Cr-Commit-Position: refs/heads/master@{#438354}

Patch Set 1 #

Patch Set 2 : Trim text output to 29K on successful runs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M third_party/qunit/src/browser_test_harness.js View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
kelvinp
PTAL
4 years ago (2016-12-13 22:48:00 UTC) #2
Jamie
lgtm
4 years ago (2016-12-13 22:52:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569373002/20001
4 years ago (2016-12-13 23:38:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 00:20:44 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-14 00:25:10 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5411331a2c4bef3cf2dd078b0a4a675b73362828
Cr-Commit-Position: refs/heads/master@{#438354}

Powered by Google App Engine
This is Rietveld 408576698