Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2575243002: Changes DesktopNativeWidgetAura to not call InitHost or window->Show() (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes DesktopNativeWidgetAura to not call InitHost or window->Show() DesktopWindowTreeHostMus needs WindowTreeHost::window() to only be shown when Show is called. This is important as the visibility of window() is mirrored in the server. To enable that this patch moves the responsibility of calling InitHost() and Show from DesktopNativeWidgetAura to DesktopWindowTreeHost. InitHost() must be called before Show(), hence the need to move InitHost in addition to Show(). BUG=672932 TEST=covered by tests R=erg@chromium.org Committed: https://crrev.com/3ed2f8511467a6010f1319ec211149aa4c7d1ee4 Cr-Commit-Position: refs/heads/master@{#438701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2 lines) Patch
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/views/mus/desktop_window_tree_host_mus_unittest.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
4 years ago (2016-12-14 23:30:23 UTC) #1
Elliot Glaysher
lgtm
4 years ago (2016-12-14 23:44:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575243002/1
4 years ago (2016-12-14 23:47:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 01:22:29 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-15 01:26:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ed2f8511467a6010f1319ec211149aa4c7d1ee4
Cr-Commit-Position: refs/heads/master@{#438701}

Powered by Google App Engine
This is Rietveld 408576698