Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2575233002:
Always retarget blur events to the root of the focused node (Closed)
|
Created:
4 years ago by David Tseng Modified:
4 years ago Reviewers:
dmazzoni CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAlways retarget blur events to the root of the focused node
Given events a_1, .., a_n that come in in the same update,
where a_i is a blur and a_j is focus (i < j).
Then, a_i's update params focused id will point to a_j's node.
As a result, we never actually fire a_j properly since it was seen as "already" focused.
TEST=navigate context menus in files app.
BUG=668775
Committed: https://crrev.com/7eb1a5afbc2fe166c92ecccc60c46261dd604ad2
Cr-Commit-Position: refs/heads/master@{#439116}
Patch Set 1 #Patch Set 2 : Fix test. #Messages
Total messages: 20 (11 generated)
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
lgtm
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dtseng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2575233002/#ps20001 (title: "Fix test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Always retarget blur events to the root of the focused node Given events a_1, .., a_n that come in in the same update, where a_i is a blur and a_j is focus (i < j). Then, a_i's update params focused id will point to a_j's node. As a result, we never actually fire a_j properly since it was seen as "already" focused. TEST=navigate context menus in files app. BUG= ========== to ========== Always retarget blur events to the root of the focused node Given events a_1, .., a_n that come in in the same update, where a_i is a blur and a_j is focus (i < j). Then, a_i's update params focused id will point to a_j's node. As a result, we never actually fire a_j properly since it was seen as "already" focused. TEST=navigate context menus in files app. BUG=668775 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481901887612430,
"parent_rev": "b601865b0e9bdd976a482fad584e3ba52c603cd4", "commit_rev":
"5aa3f462d5c4fdf66528fe1000556da228232b2b"}
Message was sent while issue was closed.
Description was changed from ========== Always retarget blur events to the root of the focused node Given events a_1, .., a_n that come in in the same update, where a_i is a blur and a_j is focus (i < j). Then, a_i's update params focused id will point to a_j's node. As a result, we never actually fire a_j properly since it was seen as "already" focused. TEST=navigate context menus in files app. BUG=668775 ========== to ========== Always retarget blur events to the root of the focused node Given events a_1, .., a_n that come in in the same update, where a_i is a blur and a_j is focus (i < j). Then, a_i's update params focused id will point to a_j's node. As a result, we never actually fire a_j properly since it was seen as "already" focused. TEST=navigate context menus in files app. BUG=668775 Review-Url: https://codereview.chromium.org/2575233002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Always retarget blur events to the root of the focused node Given events a_1, .., a_n that come in in the same update, where a_i is a blur and a_j is focus (i < j). Then, a_i's update params focused id will point to a_j's node. As a result, we never actually fire a_j properly since it was seen as "already" focused. TEST=navigate context menus in files app. BUG=668775 Review-Url: https://codereview.chromium.org/2575233002 ========== to ========== Always retarget blur events to the root of the focused node Given events a_1, .., a_n that come in in the same update, where a_i is a blur and a_j is focus (i < j). Then, a_i's update params focused id will point to a_j's node. As a result, we never actually fire a_j properly since it was seen as "already" focused. TEST=navigate context menus in files app. BUG=668775 Committed: https://crrev.com/7eb1a5afbc2fe166c92ecccc60c46261dd604ad2 Cr-Commit-Position: refs/heads/master@{#439116} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7eb1a5afbc2fe166c92ecccc60c46261dd604ad2 Cr-Commit-Position: refs/heads/master@{#439116} |
