Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 25752005: Geolocation: delete GpsLocationProvider and third_party/gpsd/ (Closed)

Created:
7 years, 2 months ago by Michael van Ouwerkerk
Modified:
7 years, 2 months ago
Reviewers:
joth, brettw, jam, timvolodine
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Michael van Ouwerkerk, bulach, joth, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Geolocation: delete GpsLocationProvider and third_party/gpsd/ The GpsLocationProvider is not actually used anywhere, and has most likely bit rotted after years of no maintenance. It is brittle code written for a specific version (3.1) of gpsd that is now outdated. The only Chrome version that had this feature enabled (ChromeOS) makes no use of it as no hardware was ever shipped that used GPS. TBR=jam,brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227104

Patch Set 1 #

Total comments: 2

Patch Set 2 : Return a NULL system location provider in LocationArbitratorImpl. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2571 lines) Patch
M build/common.gypi View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +0 lines, -69 lines 0 comments Download
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/geolocation/gps_location_provider_linux.h View 1 chunk +0 lines, -105 lines 0 comments Download
D content/browser/geolocation/gps_location_provider_linux.cc View 1 chunk +0 lines, -302 lines 0 comments Download
D content/browser/geolocation/gps_location_provider_unittest_linux.cc View 1 chunk +0 lines, -208 lines 0 comments Download
M content/browser/geolocation/location_arbitrator_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M content/content_tests.gypi View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/gpsd/COPYING View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/gpsd/README.chromium View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/gpsd/release-3.1/gps.h View 1 chunk +0 lines, -1809 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Michael van Ouwerkerk
timvolodine for geolocation brettw for third_party
7 years, 2 months ago (2013-10-03 11:40:56 UTC) #1
joth
https://codereview.chromium.org/25752005/diff/1/content/browser/geolocation/gps_location_provider_linux.cc File content/browser/geolocation/gps_location_provider_linux.cc (left): https://codereview.chromium.org/25752005/diff/1/content/browser/geolocation/gps_location_provider_linux.cc#oldcode298 content/browser/geolocation/gps_location_provider_linux.cc:298: LocationProvider* NewSystemLocationProvider() { you'll need to compile in the ...
7 years, 2 months ago (2013-10-03 12:00:58 UTC) #2
Michael van Ouwerkerk
https://codereview.chromium.org/25752005/diff/1/content/browser/geolocation/gps_location_provider_linux.cc File content/browser/geolocation/gps_location_provider_linux.cc (left): https://codereview.chromium.org/25752005/diff/1/content/browser/geolocation/gps_location_provider_linux.cc#oldcode298 content/browser/geolocation/gps_location_provider_linux.cc:298: LocationProvider* NewSystemLocationProvider() { On 2013/10/03 12:00:59, joth wrote: > ...
7 years, 2 months ago (2013-10-03 12:51:12 UTC) #3
timvolodine
lgtm
7 years, 2 months ago (2013-10-03 14:19:21 UTC) #4
joth
lgtm On 3 October 2013 15:19, <timvolodine@chromium.org> wrote: > lgtm > > > > https://codereview.chromium.**org/25752005/<https://codereview.chromium.org/25752005/> ...
7 years, 2 months ago (2013-10-03 14:45:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/25752005/8001
7 years, 2 months ago (2013-10-04 13:38:00 UTC) #6
Michael van Ouwerkerk
+ jam as reviewer for content/
7 years, 2 months ago (2013-10-04 13:39:50 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-04 13:45:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/25752005/35001
7 years, 2 months ago (2013-10-04 15:33:08 UTC) #9
commit-bot: I haz the power
Change committed as 227104
7 years, 2 months ago (2013-10-04 22:02:02 UTC) #10
jam
7 years, 2 months ago (2013-10-07 19:35:59 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698