chromeos: Tie tablet power button to --enable-touchview.

chromeos: Tie tablet power button to --enable-touchview.

Remove the --ash-enable-tablet-power-button switch and
instead enable tablet-style power button behavior whenever
the --enable-touchview switch is set. This matches the logic
for enabling the old "quick lock" power button behavior that
was replaced by tablet-style behavior.

BUG=674176, 633304
Committed: https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4
Cr-Commit-Position: refs/heads/master@{#438663}

[Daniel Erat, 2016-12-14 21:45:27]

derat@chromium.org changed reviewers:
+ jamescook@chromium.org, warx@chromium.org

[Daniel Erat, 2016-12-14 21:45:32]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[Daniel Erat, 2016-12-14 21:45:44]

derat@chromium.org changed reviewers:
+ bruthig@chromium.org

[commit-bot: I haz the power, 2016-12-14 21:46:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-12-14 21:57:52]

LGTM with nit

https://codereview.chromium.org/2575183002/diff/1/ash/common/ash_switches.cc
File ash/common/ash_switches.cc (right):

https://codereview.chromium.org/2575183002/diff/1/ash/common/ash_switches.cc#...
ash/common/ash_switches.cc:65: // Enables the observation of accelerometer
events to enter touch-view mode.
Consider adding a comment here that it also changes power button functionality
and/or is the master switch for tablet-like functionality.

(If it's the latter it would be nice to rename the switch, although I can see
how that would require a bunch of changes in the chromeos side.)

[commit-bot: I haz the power, 2016-12-14 22:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:03:34]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bruthig, 2016-12-14 22:05:30]

lgtm

[Daniel Erat, 2016-12-14 22:21:20]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:21:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-12-14 22:31:35]

The CQ bit was unchecked by derat@chromium.org

[Daniel Erat, 2016-12-14 22:31:42]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2016-12-14 22:31:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, bruthig@chromium.org
Link to the patchset: https://codereview.chromium.org/2575183002/#ps20001
(title: "add switch namespaces :-/")

[commit-bot: I haz the power, 2016-12-14 22:32:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:08:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481754702327370,
"parent_rev": "e942218a9553f8b1692b5e198b5a0d23e4a8006c", "commit_rev":
"c54d89adf81ce2cce52470dab3fe128d4003e3cf"}

[commit-bot: I haz the power, 2016-12-14 23:09:29]

Description was changed from

==========
chromeos: Tie tablet power button to --enable-touchview.

Remove the --ash-enable-tablet-power-button switch and
instead enable tablet-style power button behavior whenever
the --enable-touchview switch is set. This matches the logic
for enabling the old "quick lock" power button behavior that
was replaced by tablet-style behavior.

BUG=674176,633304
==========

to

==========
chromeos: Tie tablet power button to --enable-touchview.

Remove the --ash-enable-tablet-power-button switch and
instead enable tablet-style power button behavior whenever
the --enable-touchview switch is set. This matches the logic
for enabling the old "quick lock" power button behavior that
was replaced by tablet-style behavior.

BUG=674176,633304

Review-Url: https://codereview.chromium.org/2575183002
==========

[commit-bot: I haz the power, 2016-12-14 23:09:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 23:12:47]

Description was changed from

==========
chromeos: Tie tablet power button to --enable-touchview.

Remove the --ash-enable-tablet-power-button switch and
instead enable tablet-style power button behavior whenever
the --enable-touchview switch is set. This matches the logic
for enabling the old "quick lock" power button behavior that
was replaced by tablet-style behavior.

BUG=674176,633304

Review-Url: https://codereview.chromium.org/2575183002
==========

to

==========
chromeos: Tie tablet power button to --enable-touchview.

Remove the --ash-enable-tablet-power-button switch and
instead enable tablet-style power button behavior whenever
the --enable-touchview switch is set. This matches the logic
for enabling the old "quick lock" power button behavior that
was replaced by tablet-style behavior.

BUG=674176,633304

Committed: https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4
Cr-Commit-Position: refs/heads/master@{#438663}
==========

[commit-bot: I haz the power, 2016-12-14 23:12:48]

Patchset 2 (id:??) landed as
https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4
Cr-Commit-Position: refs/heads/master@{#438663}