Issue 2575153002: Merge to M56 "[DevTools] Make SourceFrame.setEditable work."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2575153002: Merge to M56 "[DevTools] Make SourceFrame.setEditable work." (Closed)

Created:
4 years ago by dgozman

Modified:
4 years ago

Reviewers:
lushnikov

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Merge to M56 "[DevTools] Make SourceFrame.setEditable work." > [DevTools] Make SourceFrame.setEditable work. > > There were two bugs in readonly handling. > > BUG=673074 > > Review-Url: https://codereview.chromium.org/2567633003 > Cr-Commit-Position: refs/heads/master@{#437772} (cherry picked from commit 1baf153a336c4601f9092285ae0a8e4686fc4c88) TBR=lushnikov@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9e13bd3af7eb1a99aaab3de4815424b5a9c9f9c7

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

dgozman

4 years ago (2016-12-14 20:09:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9e13bd3af7eb1a99aaab3de4815424b5a9c9f9c7.