Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2567633003:
[DevTools] Make SourceFrame.setEditable work. (Closed)
|
Created:
4 years ago by dgozman Modified:
4 years ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Make SourceFrame.setEditable work.
There were two bugs in readonly handling.
BUG=673074
Committed: https://crrev.com/1baf153a336c4601f9092285ae0a8e4686fc4c88
Cr-Commit-Position: refs/heads/master@{#437772}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 26 (14 generated)
dgozman@chromium.org changed reviewers: + lushnikov@chromium.org
Take a look please.
https://codereview.chromium.org/2567633003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js (right): https://codereview.chromium.org/2567633003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:275: this.setEditable(this._canEditSource()); how did it work at all?
The CQ bit was checked by lushnikov@chromium.org
lgtm
The CQ bit was unchecked by lushnikov@chromium.org
Description was changed from ========== [DevTools] Make SourceFrame.setEditable work. There were two bugs in readonly handling. BUG=none ========== to ========== [DevTools] Make SourceFrame.setEditable work. There were two bugs in readonly handling. BUG=673074 ==========
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481387845978380, "parent_rev":
"281b2da3661edf1cab229dc1d8c7f64198e23eee", "commit_rev":
"d9951ac8c08290b8d1a5b0eb8a160f85eb65dbde"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Make SourceFrame.setEditable work. There were two bugs in readonly handling. BUG=673074 ========== to ========== [DevTools] Make SourceFrame.setEditable work. There were two bugs in readonly handling. BUG=673074 Review-Url: https://codereview.chromium.org/2567633003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Make SourceFrame.setEditable work. There were two bugs in readonly handling. BUG=673074 Review-Url: https://codereview.chromium.org/2567633003 ========== to ========== [DevTools] Make SourceFrame.setEditable work. There were two bugs in readonly handling. BUG=673074 Committed: https://crrev.com/1baf153a336c4601f9092285ae0a8e4686fc4c88 Cr-Commit-Position: refs/heads/master@{#437772} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1baf153a336c4601f9092285ae0a8e4686fc4c88 Cr-Commit-Position: refs/heads/master@{#437772} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
