Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2575133002: [parser] remove %catch parsing (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] remove %catch parsing Promise catch prediction no longer has to be threaded through the parser since the code using %catch has been moved to TF codestubs. This is currently dead code. BUG=v8:5343, v8:5741 Committed: https://crrev.com/bbc68d41103498b7cd311cfc159998acc40a4c1a Cr-Commit-Position: refs/heads/master@{#41701}

Patch Set 1 #

Patch Set 2 : improve comment #

Patch Set 3 : try improving the comment again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -24 lines) Patch
M src/ast/ast.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ast/prettyprinter.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
gsathya
4 years ago (2016-12-14 19:01:48 UTC) #9
Yang
lgtm
4 years ago (2016-12-14 19:06:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575133002/40001
4 years ago (2016-12-14 19:28:31 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30602)
4 years ago (2016-12-14 19:35:28 UTC) #16
Dan Ehrenberg
lgtm
4 years ago (2016-12-14 21:01:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575133002/40001
4 years ago (2016-12-14 21:01:32 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-14 21:03:55 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-14 21:04:45 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bbc68d41103498b7cd311cfc159998acc40a4c1a
Cr-Commit-Position: refs/heads/master@{#41701}

Powered by Google App Engine
This is Rietveld 408576698