Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 257513007: [Android] ForeignSessionHelper string memory leak fix. (Closed)

Created:
6 years, 8 months ago by Kibeom Kim (inactive)
Modified:
6 years, 8 months ago
Reviewers:
Feng Qian, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Delete local java reference every loop. In ForeignSessionHelper class, there were two places we allocate ScopedJavaLocalRef<jstring> inside a loop and doesn't delete. The Java local references are cleaned upon returning to Java, but there is 512 local reference hard-limit so we should delete it every loop to avoid hitting the limit. BUG=366659 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266398

Patch Set 1 #

Patch Set 2 : more cases #

Patch Set 3 : only loop was the problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/android/foreign_session_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Kibeom Kim (inactive)
6 years, 8 months ago (2014-04-24 21:25:59 UTC) #1
Kibeom Kim (inactive)
ptal
6 years, 8 months ago (2014-04-24 23:39:42 UTC) #2
Feng Qian
On 2014/04/24 23:39:42, Kibeom Kim wrote: > ptal lgtm
6 years, 8 months ago (2014-04-24 23:50:12 UTC) #3
Kibeom Kim (inactive)
On 2014/04/24 23:50:12, Feng Qian wrote: > On 2014/04/24 23:39:42, Kibeom Kim wrote: > > ...
6 years, 8 months ago (2014-04-25 03:17:39 UTC) #4
Kibeom Kim (inactive)
+owner @newt
6 years, 8 months ago (2014-04-25 20:48:32 UTC) #5
newt (away)
lgtm
6 years, 8 months ago (2014-04-25 22:05:39 UTC) #6
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 8 months ago (2014-04-25 22:05:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/257513007/30001
6 years, 8 months ago (2014-04-25 22:29:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 00:26:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 00:26:16 UTC) #10
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 8 months ago (2014-04-26 00:26:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/257513007/30001
6 years, 8 months ago (2014-04-26 00:31:22 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 06:33:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 06:33:58 UTC) #14
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 8 months ago (2014-04-26 06:36:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/257513007/30001
6 years, 8 months ago (2014-04-26 06:37:19 UTC) #16
commit-bot: I haz the power
Change committed as 266398
6 years, 8 months ago (2014-04-27 00:18:10 UTC) #17
tapted
6 years, 8 months ago (2014-04-28 01:04:18 UTC) #18
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/254713007/ by tapted@chromium.org.

The reason for reverting is: The CQ seems to have ignored the trybot failures on
`android_dbg_triggered_tests`. Step `unit_tests` failing since
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/13319

Failures on GCMServiceTest.* and ZipTest.ZipTimeStamp. Suspecting this CL..

Powered by Google App Engine
This is Rietveld 408576698