chrome/browser/android/foreign_session_helper.cc - Issue 257513007: [Android] ForeignSessionHelper string memory leak fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/foreign_session_helper.cc

Issue 257513007: [Android] ForeignSessionHelper string memory leak fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: only loop was the problem Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/foreign_session_helper.cc

diff --git a/chrome/browser/android/foreign_session_helper.cc b/chrome/browser/android/foreign_session_helper.cc

index 38d7c1cbbb153637180e13c8f27185f438f95c61..f1b35656673af4d3bef953110ac605f67e658dce 100644

--- a/chrome/browser/android/foreign_session_helper.cc

+++ b/chrome/browser/android/foreign_session_helper.cc

@@ -106,8 +106,8 @@ void CopyTabsToJava(

Java_ForeignSessionHelper_pushTab(

env, j_window.obj(),

- ConvertUTF8ToJavaString(env, tab_url.spec()).Release(),

- ConvertUTF16ToJavaString(env, current_navigation.title()).Release(),

+ ConvertUTF8ToJavaString(env, tab_url.spec()).obj(),

+ ConvertUTF16ToJavaString(env, current_navigation.title()).obj(),

session_tab.timestamp.ToJavaTime(),

session_tab.tab_id.id());

}

@@ -236,8 +236,8 @@ jboolean ForeignSessionHelper::GetForeignSessions(JNIEnv* env,

Java_ForeignSessionHelper_pushSession(

env,

result,

- ConvertUTF8ToJavaString(env, session.session_tag).Release(),

- ConvertUTF8ToJavaString(env, session.session_name).Release(),

+ ConvertUTF8ToJavaString(env, session.session_tag).obj(),

+ ConvertUTF8ToJavaString(env, session.session_name).obj(),

session.device_type,

session.modified_time.ToJavaTime()));

« no previous file with comments | « no previous file | no next file » | no next file with comments »