Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2575083002: Pass ClosedWorld directly to codegen tasks (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -145 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 4 chunks +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 9 chunks +31 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 7 chunks +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 13 chunks +30 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 4 chunks +16 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 8 chunks +24 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 9 chunks +47 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 5 chunks +9 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/value_range_analyzer.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/tracer.dart View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years ago (2016-12-14 14:41:45 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2575083002/diff/1/pkg/compiler/lib/src/common/backend_api.dart File pkg/compiler/lib/src/common/backend_api.dart (right): https://codereview.chromium.org/2575083002/diff/1/pkg/compiler/lib/src/common/backend_api.dart#newcode317 pkg/compiler/lib/src/common/backend_api.dart:317: void onCodegenEnd(); ; => {} (most other code ...
4 years ago (2016-12-15 19:24:47 UTC) #3
Johnni Winther
https://codereview.chromium.org/2575083002/diff/1/pkg/compiler/lib/src/common/backend_api.dart File pkg/compiler/lib/src/common/backend_api.dart (right): https://codereview.chromium.org/2575083002/diff/1/pkg/compiler/lib/src/common/backend_api.dart#newcode317 pkg/compiler/lib/src/common/backend_api.dart:317: void onCodegenEnd(); On 2016/12/15 19:24:47, Siggi Cherem (dart-lang) wrote: ...
4 years ago (2016-12-16 09:17:00 UTC) #4
Johnni Winther
4 years ago (2016-12-16 09:22:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b11484e49c93bcdc24c0e840c5eecc71624ece23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698