Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: pkg/compiler/lib/src/ssa/ssa.dart

Issue 2575083002: Pass ClosedWorld directly to codegen tasks (Closed)
Patch Set: Updated cf. comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/optimize.dart ('k') | pkg/compiler/lib/src/ssa/ssa_tracer.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library ssa; 5 library ssa;
6 6
7 import '../common/codegen.dart' show CodegenWorkItem; 7 import '../common/codegen.dart' show CodegenWorkItem;
8 import '../common/tasks.dart' show CompilerTask; 8 import '../common/tasks.dart' show CompilerTask;
9 import '../elements/elements.dart' show Element, FunctionElement; 9 import '../elements/elements.dart' show Element, FunctionElement;
10 import '../io/source_information.dart'; 10 import '../io/source_information.dart';
11 import '../js/js.dart' as js; 11 import '../js/js.dart' as js;
12 import '../js_backend/backend.dart' show JavaScriptBackend, FunctionCompiler; 12 import '../js_backend/backend.dart' show JavaScriptBackend, FunctionCompiler;
13 import '../world.dart' show ClosedWorld;
13 14
14 import 'builder.dart'; 15 import 'builder.dart';
15 import 'builder_kernel.dart'; 16 import 'builder_kernel.dart';
16 import 'codegen.dart'; 17 import 'codegen.dart';
17 import 'nodes.dart'; 18 import 'nodes.dart';
18 import 'optimize.dart'; 19 import 'optimize.dart';
19 20
20 class SsaFunctionCompiler implements FunctionCompiler { 21 class SsaFunctionCompiler implements FunctionCompiler {
21 final SsaCodeGeneratorTask generator; 22 final SsaCodeGeneratorTask generator;
22 final SsaBuilderTask builder; 23 final SsaBuilderTask builder;
23 final SsaKernelBuilderTask builderKernel; 24 final SsaKernelBuilderTask builderKernel;
24 final SsaOptimizerTask optimizer; 25 final SsaOptimizerTask optimizer;
25 final JavaScriptBackend backend; 26 final JavaScriptBackend backend;
26 final bool useKernel; 27 final bool useKernel;
27 28
28 SsaFunctionCompiler(JavaScriptBackend backend, 29 SsaFunctionCompiler(JavaScriptBackend backend,
29 SourceInformationStrategy sourceInformationFactory, this.useKernel) 30 SourceInformationStrategy sourceInformationFactory, this.useKernel)
30 : generator = new SsaCodeGeneratorTask(backend, sourceInformationFactory), 31 : generator = new SsaCodeGeneratorTask(backend, sourceInformationFactory),
31 builder = new SsaBuilderTask(backend, sourceInformationFactory), 32 builder = new SsaBuilderTask(backend, sourceInformationFactory),
32 builderKernel = 33 builderKernel =
33 new SsaKernelBuilderTask(backend, sourceInformationFactory), 34 new SsaKernelBuilderTask(backend, sourceInformationFactory),
34 optimizer = new SsaOptimizerTask(backend), 35 optimizer = new SsaOptimizerTask(backend),
35 backend = backend; 36 backend = backend;
36 37
37 /// Generates JavaScript code for `work.element`. 38 /// Generates JavaScript code for `work.element`.
38 /// Using the ssa builder, optimizer and codegenerator. 39 /// Using the ssa builder, optimizer and codegenerator.
39 js.Fun compile(CodegenWorkItem work) { 40 js.Fun compile(CodegenWorkItem work, ClosedWorld closedWorld) {
40 HGraph graph = useKernel ? builderKernel.build(work) : builder.build(work); 41 HGraph graph = useKernel
41 optimizer.optimize(work, graph); 42 ? builderKernel.build(work, closedWorld)
43 : builder.build(work, closedWorld);
44 optimizer.optimize(work, graph, closedWorld);
42 Element element = work.element; 45 Element element = work.element;
43 js.Expression result = generator.generateCode(work, graph); 46 js.Expression result = generator.generateCode(work, graph, closedWorld);
44 if (element is FunctionElement) { 47 if (element is FunctionElement) {
45 // TODO(sigmund): replace by kernel transformer when `useKernel` is true. 48 // TODO(sigmund): replace by kernel transformer when `useKernel` is true.
46 result = backend.rewriteAsync(element, result); 49 result = backend.rewriteAsync(element, result);
47 } 50 }
48 return result; 51 return result;
49 } 52 }
50 53
51 Iterable<CompilerTask> get tasks { 54 Iterable<CompilerTask> get tasks {
52 return <CompilerTask>[ 55 return <CompilerTask>[
53 useKernel ? builderKernel : builder, 56 useKernel ? builderKernel : builder,
54 optimizer, 57 optimizer,
55 generator 58 generator
56 ]; 59 ];
57 } 60 }
58 } 61 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/ssa/optimize.dart ('k') | pkg/compiler/lib/src/ssa/ssa_tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698