Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2575003003:
[Android] Use local build of chromium_commands.dex.jar in chromium tests. (Closed)
|
Created:
4 years ago by jbudorick Modified:
4 years ago Reviewers:
mikecase (-- gone --) CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Android] Use local build of chromium_commands.dex.jar in chromium tests.
Without this, we were downloading chromium_commands.dex.jar from GCS every
time we tried to use it. This is both unnecessary and potentially problematic,
as catapult/devil's downloading mechanism is currently prone to hanging with
lock failures.
With this change, we will instead use the locally built version of
chromium_commands.dex.jar when available.
BUG=674172
Committed: https://crrev.com/6e2cfec2af8f4129669c22554ea17d289ba36f2e
Cr-Commit-Position: refs/heads/master@{#439537}
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jbudorick@chromium.org changed reviewers: + mikecase@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
friendly ping
lgtm. But what is chromium_commands.dex.jar? O_o
On 2016/12/19 18:39:11, mikecase wrote: > lgtm. But what is chromium_commands.dex.jar? O_o https://codesearch.chromium.org/chromium/src/build/android/pylib/device/comma...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482178322347650, "parent_rev":
"1cb5b2d5e28fcf87f50ab7e3d23a9a03928db6d4", "commit_rev":
"dc127061ecf0f06de5ffb0405b346a357651c1b1"}
Message was sent while issue was closed.
Description was changed from ========== [Android] Use local build of chromium_commands.dex.jar in chromium tests. Without this, we were downloading chromium_commands.dex.jar from GCS every time we tried to use it. This is both unnecessary and potentially problematic, as catapult/devil's downloading mechanism is currently prone to hanging with lock failures. With this change, we will instead use the locally built version of chromium_commands.dex.jar when available. BUG=674172 ========== to ========== [Android] Use local build of chromium_commands.dex.jar in chromium tests. Without this, we were downloading chromium_commands.dex.jar from GCS every time we tried to use it. This is both unnecessary and potentially problematic, as catapult/devil's downloading mechanism is currently prone to hanging with lock failures. With this change, we will instead use the locally built version of chromium_commands.dex.jar when available. BUG=674172 Review-Url: https://codereview.chromium.org/2575003003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Android] Use local build of chromium_commands.dex.jar in chromium tests. Without this, we were downloading chromium_commands.dex.jar from GCS every time we tried to use it. This is both unnecessary and potentially problematic, as catapult/devil's downloading mechanism is currently prone to hanging with lock failures. With this change, we will instead use the locally built version of chromium_commands.dex.jar when available. BUG=674172 Review-Url: https://codereview.chromium.org/2575003003 ========== to ========== [Android] Use local build of chromium_commands.dex.jar in chromium tests. Without this, we were downloading chromium_commands.dex.jar from GCS every time we tried to use it. This is both unnecessary and potentially problematic, as catapult/devil's downloading mechanism is currently prone to hanging with lock failures. With this change, we will instead use the locally built version of chromium_commands.dex.jar when available. BUG=674172 Committed: https://crrev.com/6e2cfec2af8f4129669c22554ea17d289ba36f2e Cr-Commit-Position: refs/heads/master@{#439537} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6e2cfec2af8f4129669c22554ea17d289ba36f2e Cr-Commit-Position: refs/heads/master@{#439537} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
