Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2574973002:
Use content::IsBrowserSideNavigationEnabled() in ReloadCacheControlBrowserTest (Closed)
|
Created:
4 years ago by Takashi Toyoshima Modified:
4 years ago CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse content::IsBrowserSideNavigationEnabled() in ReloadCacheControlBrowserTest
To check if browser side navigation is enabled, use
content::IsBrowserSideNavigationEnabled() instead of checking command
line directly.
BUG=671545
Committed: https://crrev.com/4d8bd78d8de55ceb02be5ed9d6ad4a4d2f731d78
Cr-Commit-Position: refs/heads/master@{#438739}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Use content::IsBrowserSideNavigationEnabled() in ReloadCacheControlBrowserTest To check if browser side navigation is enabled, use content::IsBrowserSideNavigationEnabled() instead of checking command line directly. BUG=671545 ========== to ========== Use content::IsBrowserSideNavigationEnabled() in ReloadCacheControlBrowserTest To check if browser side navigation is enabled, use content::IsBrowserSideNavigationEnabled() instead of checking command line directly. BUG=671545 ==========
toyoshim@chromium.org changed reviewers: + carlosk@chromium.org
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
toyoshim@chromium.org changed reviewers: + clamy@chromium.org
can you take a look?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks! Lgtm.
On 2016/12/14 15:54:10, clamy wrote: > Thanks! Lgtm. Ditto! :)
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481775920708300, "parent_rev":
"b09375a8325ed392cfe41113a3f71a299bac32db", "commit_rev":
"2146c4b5b7816f6639780bc2c1f53249a41446d8"}
Message was sent while issue was closed.
Description was changed from ========== Use content::IsBrowserSideNavigationEnabled() in ReloadCacheControlBrowserTest To check if browser side navigation is enabled, use content::IsBrowserSideNavigationEnabled() instead of checking command line directly. BUG=671545 ========== to ========== Use content::IsBrowserSideNavigationEnabled() in ReloadCacheControlBrowserTest To check if browser side navigation is enabled, use content::IsBrowserSideNavigationEnabled() instead of checking command line directly. BUG=671545 Review-Url: https://codereview.chromium.org/2574973002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use content::IsBrowserSideNavigationEnabled() in ReloadCacheControlBrowserTest To check if browser side navigation is enabled, use content::IsBrowserSideNavigationEnabled() instead of checking command line directly. BUG=671545 Review-Url: https://codereview.chromium.org/2574973002 ========== to ========== Use content::IsBrowserSideNavigationEnabled() in ReloadCacheControlBrowserTest To check if browser side navigation is enabled, use content::IsBrowserSideNavigationEnabled() instead of checking command line directly. BUG=671545 Committed: https://crrev.com/4d8bd78d8de55ceb02be5ed9d6ad4a4d2f731d78 Cr-Commit-Position: refs/heads/master@{#438739} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4d8bd78d8de55ceb02be5ed9d6ad4a4d2f731d78 Cr-Commit-Position: refs/heads/master@{#438739} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
