Fix Android unit_tests failures with PlzNavigate.

Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that defers a request. The test harness assumed they're always synchronous. Fix by waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The RenderFrameHost test harness fakes navigations but doesn't handle multiple loads per RenderFrameHost very well (specifically, if a pending or speculative RFH is used). Fixing this would necessitate moving a bunch of methods from RenderFrameHostTester to WebContentsTester and updating all the tests. Additionally, the specific test harness code in NetErrorTabHelperTest has issues in that it doesn't use the pending/speculative RFH. The easiest solution here is to split the one unit test into three.

This fixes the 225 failing unit_tests on Android.

BUG=673806
Committed: https://crrev.com/0265e75fa260668610c0b708b91aff6dfcdbfc00
Cr-Commit-Position: refs/heads/master@{#438855}

[jam, 2016-12-14 02:14:23]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:15:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 02:25:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 02:25:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-12-14 05:09:24]

Description was changed from

==========
foo

BUG=
==========

to

==========
foo

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-12-14 05:09:27]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2016-12-14 05:09:44]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-14 05:09:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 05:16:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 05:16:27]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-12-14 17:04:06]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 17:04:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 17:12:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:12:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jam, 2016-12-14 17:19:39]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 17:20:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 17:30:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:30:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-12-14 20:27:41]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 20:28:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:40:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:40:05]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-12-14 22:45:13]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:45:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-12-14 22:53:21]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:53:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:14:10]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-12-15 00:03:19]

Description was changed from

==========
foo

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android
ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that
defers a request. The test harness assumed they're always synchronous. Fix by
waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The
RenderViewHost test harness fakes navigations but doesn't handle multiple loads
per RenderFrameHost very well. Additionally, the specific test harness code also
has issues in that it doesn't use the pending RFH. The easiest solution here is
to split the one unit test into three.

BUG=673806
==========

[jam, 2016-12-15 00:03:19]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org

[jam, 2016-12-15 00:03:38]

Description was changed from

==========
Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android
ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that
defers a request. The test harness assumed they're always synchronous. Fix by
waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The
RenderViewHost test harness fakes navigations but doesn't handle multiple loads
per RenderFrameHost very well. Additionally, the specific test harness code also
has issues in that it doesn't use the pending RFH. The easiest solution here is
to split the one unit test into three.

BUG=673806
==========

to

==========
Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android
ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that
defers a request. The test harness assumed they're always synchronous. Fix by
waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The
RenderViewHost test harness fakes navigations but doesn't handle multiple loads
per RenderFrameHost very well. Additionally, the specific test harness code also
has issues in that it doesn't use the pending RFH. The easiest solution here is
to split the one unit test into three.

This fixes the 225 failing unit_tests on Android.

BUG=673806
==========

[jam, 2016-12-15 00:03:47]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 00:04:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 01:04:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 01:04:43]

Dry run: This issue passed the CQ dry run.

[arthursonzogni, 2016-12-15 16:32:39]

arthursonzogni@chromium.org changed reviewers:
+ arthursonzogni@chromium.org

[arthursonzogni, 2016-12-15 16:32:39]

I read diagonally because scottmg will do the review and I am not a committer
yet.
Some nits:

https://codereview.chromium.org/2574953002/diff/120001/chrome/browser/net/net...
File chrome/browser/net/net_error_tab_helper_unittest.cc (right):

https://codereview.chromium.org/2574953002/diff/120001/chrome/browser/net/net...
chrome/browser/net/net_error_tab_helper_unittest.cc:394: // once. So workaround
it by puting each test case in a separate test.
Nit: s/don't/doesn't
Nit: s/puting/putting

[scottmg, 2016-12-15 17:02:32]

lgtm

[jam, 2016-12-15 17:12:04]

Description was changed from

==========
Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android
ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that
defers a request. The test harness assumed they're always synchronous. Fix by
waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The
RenderViewHost test harness fakes navigations but doesn't handle multiple loads
per RenderFrameHost very well. Additionally, the specific test harness code also
has issues in that it doesn't use the pending RFH. The easiest solution here is
to split the one unit test into three.

This fixes the 225 failing unit_tests on Android.

BUG=673806
==========

to

==========
Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android
ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that
defers a request. The test harness assumed they're always synchronous. Fix by
waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The
RenderFrameHost test harness fakes navigations but doesn't handle multiple loads
per RenderFrameHost very well (specifically, if a pending or speculative RFH is
used). Fixing this would necessitate moving a bunch of methods from
RenderFrameHostTester to WebContentsTester and updating all the tests.
Additionally, the specific test harness code in NetErrorTabHelperTest has issues
in that it doesn't use the pending/speculative RFH. The easiest solution here is
to split the one unit test into three.

This fixes the 225 failing unit_tests on Android.

BUG=673806
==========

[jam, 2016-12-15 17:12:08]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-12-15 17:12:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 17:17:46]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481821928832040,
"parent_rev": "213ec51d612cb9ba5267bed88b8adb4b92052c88", "commit_rev":
"2d882022131ed9210ed18575d20cc4c3799c56b0"}

[commit-bot: I haz the power, 2016-12-15 17:18:14]

Description was changed from

==========
Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android
ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that
defers a request. The test harness assumed they're always synchronous. Fix by
waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The
RenderFrameHost test harness fakes navigations but doesn't handle multiple loads
per RenderFrameHost very well (specifically, if a pending or speculative RFH is
used). Fixing this would necessitate moving a bunch of methods from
RenderFrameHostTester to WebContentsTester and updating all the tests.
Additionally, the specific test harness code in NetErrorTabHelperTest has issues
in that it doesn't use the pending/speculative RFH. The easiest solution here is
to split the one unit test into three.

This fixes the 225 failing unit_tests on Android.

BUG=673806
==========

to

==========
Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android
ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that
defers a request. The test harness assumed they're always synchronous. Fix by
waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The
RenderFrameHost test harness fakes navigations but doesn't handle multiple loads
per RenderFrameHost very well (specifically, if a pending or speculative RFH is
used). Fixing this would necessitate moving a bunch of methods from
RenderFrameHostTester to WebContentsTester and updating all the tests.
Additionally, the specific test harness code in NetErrorTabHelperTest has issues
in that it doesn't use the pending/speculative RFH. The easiest solution here is
to split the one unit test into three.

This fixes the 225 failing unit_tests on Android.

BUG=673806

Review-Url: https://codereview.chromium.org/2574953002
==========

[commit-bot: I haz the power, 2016-12-15 17:18:18]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-12-15 17:19:53]

Description was changed from

==========
Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android
ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that
defers a request. The test harness assumed they're always synchronous. Fix by
waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The
RenderFrameHost test harness fakes navigations but doesn't handle multiple loads
per RenderFrameHost very well (specifically, if a pending or speculative RFH is
used). Fixing this would necessitate moving a bunch of methods from
RenderFrameHostTester to WebContentsTester and updating all the tests.
Additionally, the specific test harness code in NetErrorTabHelperTest has issues
in that it doesn't use the pending/speculative RFH. The easiest solution here is
to split the one unit test into three.

This fixes the 225 failing unit_tests on Android.

BUG=673806

Review-Url: https://codereview.chromium.org/2574953002
==========

to

==========
Fix Android unit_tests failures with PlzNavigate.

The test failures all are because on Android
ChromeContentBrowserClient::CreateThrottlesForNavigation returns a throttle that
defers a request. The test harness assumed they're always synchronous. Fix by
waiting on the callback to be run asynchronously.

The other minor fix is to Android specific NetErrorTabHelperTest tests. The
RenderFrameHost test harness fakes navigations but doesn't handle multiple loads
per RenderFrameHost very well (specifically, if a pending or speculative RFH is
used). Fixing this would necessitate moving a bunch of methods from
RenderFrameHostTester to WebContentsTester and updating all the tests.
Additionally, the specific test harness code in NetErrorTabHelperTest has issues
in that it doesn't use the pending/speculative RFH. The easiest solution here is
to split the one unit test into three.

This fixes the 225 failing unit_tests on Android.

BUG=673806

Committed: https://crrev.com/0265e75fa260668610c0b708b91aff6dfcdbfc00
Cr-Commit-Position: refs/heads/master@{#438855}
==========

[commit-bot: I haz the power, 2016-12-15 17:19:54]

Patchset 6 (id:??) landed as
https://crrev.com/0265e75fa260668610c0b708b91aff6dfcdbfc00
Cr-Commit-Position: refs/heads/master@{#438855}