Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2574943002: [profiler] Add check for SFI::script() being not undefined (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Add check for SFI::script() being not undefined BUG=v8:5735 Committed: https://crrev.com/cc47e27a3739cad42fedb3d4d85525ca8353ebdc Cr-Commit-Position: refs/heads/master@{#41689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/profiler/profiler-listener.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
alph
4 years ago (2016-12-14 01:10:59 UTC) #2
Clemens Hammacher
lgtm, thanks!
4 years ago (2016-12-14 09:40:43 UTC) #3
Clemens Hammacher
lgtm, thanks!
4 years ago (2016-12-14 09:40:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574943002/1
4 years ago (2016-12-14 09:53:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 10:20:07 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-14 10:20:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc47e27a3739cad42fedb3d4d85525ca8353ebdc
Cr-Commit-Position: refs/heads/master@{#41689}

Powered by Google App Engine
This is Rietveld 408576698