Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2574923002: Add common IntegrationTest class with assertions and RunAllTests() func (Closed)

Created:
4 years ago by Robert Ogden
Modified:
4 years ago
Reviewers:
sclittle
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add common IntegrationTest class with assertions and RunAllTests() func Also cleans up command line args and HTTPResponse header processing. R=sclittle BUG=669956 Committed: https://crrev.com/3462ad04053cb5241140fb7f806c6f382f179a05 Cr-Commit-Position: refs/heads/master@{#438410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -35 lines) Patch
M tools/chrome_proxy/webdriver/common.py View 7 chunks +56 lines, -27 lines 0 comments Download
M tools/chrome_proxy/webdriver/simple_smoke.py View 3 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Ogden
4 years ago (2016-12-13 23:26:44 UTC) #1
sclittle
lgtm
4 years ago (2016-12-14 00:19:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574923002/1
4 years ago (2016-12-14 03:05:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 03:17:23 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-14 03:19:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3462ad04053cb5241140fb7f806c6f382f179a05
Cr-Commit-Position: refs/heads/master@{#438410}

Powered by Google App Engine
This is Rietveld 408576698