Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2574853002: De-flake BluetoothLowEnergyWeave* tests. (Closed)

Created:
4 years ago by Kyle Horimoto
Modified:
4 years ago
Reviewers:
Ryan Hansberry
CC:
chromium-reviews, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, jlklein+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org, tengs+watch-tether_chromium.org, brettw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

De-flake BluetoothLowEnergyWeave* tests. The issue was that ProximityAuthBluetoothLowEnergyWeaveClientConnectionTest set up "test" factories but did not un-set them once the test was over. The result is that two other tests used these test factories in their tests, which caused failed assertions. BUG=651246, 672263 Committed: https://crrev.com/dafc3e2f8edb161aa77cbd084ccb6b08b488e3df Cr-Commit-Position: refs/heads/master@{#438305}

Patch Set 1 #

Patch Set 2 : Removed TODO comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -86 lines) Patch
M components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc View 1 8 chunks +8 lines, -16 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc View 1 35 chunks +35 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Kyle Horimoto
4 years ago (2016-12-13 19:52:51 UTC) #2
Ryan Hansberry
lgtm
4 years ago (2016-12-13 19:55:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574853002/20001
4 years ago (2016-12-13 19:56:56 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-13 22:03:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dafc3e2f8edb161aa77cbd084ccb6b08b488e3df
Cr-Commit-Position: refs/heads/master@{#438305}

Powered by Google App Engine
This is Rietveld 408576698