Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc

Issue 2574853002: De-flake BluetoothLowEnergyWeave* tests. (Closed)
Patch Set: Removed TODO comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc
diff --git a/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc b/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc
index c6dffaf406638e2c820572b6aae2aa88dd1008ad..f1a31775a013df3d7cc05913de6d568e13e04896 100644
--- a/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc
+++ b/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc
@@ -48,9 +48,8 @@ class ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest
ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest);
};
-// TODO(http://crbug.com/651246) this test is flaky.
TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
- DISABLED_CreateConnectionRequestTest) {
+ CreateConnectionRequestTest) {
std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator> generator =
BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance();
@@ -74,9 +73,8 @@ TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
EXPECT_EQ(expected, packet);
}
-// TODO(http://crbug.com/651246) this test is flaky.
TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
- DISABLED_CreateConnectionResponseWithDefaultPacketSizeTest) {
+ CreateConnectionResponseWithDefaultPacketSizeTest) {
std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator> generator =
BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance();
@@ -95,9 +93,8 @@ TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
EXPECT_EQ(expected_default, packet);
}
-// TODO(http://crbug.com/651246) this test is flaky.
TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
- DISABLED_CreateConnectionResponseWithSelectedPacketSizeTest) {
+ CreateConnectionResponseWithSelectedPacketSizeTest) {
std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator> generator =
BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance();
@@ -119,9 +116,8 @@ TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
EXPECT_EQ(expected_selected, packet);
}
-// TODO(http://crbug.com/651246) this test is flaky.
TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
- DISABLED_CreateConnectionCloseTest) {
+ CreateConnectionCloseTest) {
// Reason for close spec of uWeave.
// 0x00: Close without error
// 0x01: Unknown error
@@ -138,9 +134,8 @@ TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
TestConnectionCloseWithReason(ReasonForClose::APPLICATION_ERROR, 0x80);
}
-// TODO(http://crbug.com/651246) this test is flaky.
TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
- DISABLED_EncodeDataMessageWithDefaultPacketSizeTest) {
+ EncodeDataMessageWithDefaultPacketSizeTest) {
std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator> generator =
BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance();
@@ -172,9 +167,8 @@ TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
EXPECT_EQ(expected, packets);
}
-// TODO(http://crbug.com/651246) this test is flaky.
TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
- DISABLED_EncodeDataMessageWithSelectedPacketSizeTest) {
+ EncodeDataMessageWithSelectedPacketSizeTest) {
std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator> generator =
BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance();
@@ -225,9 +219,8 @@ TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
EXPECT_EQ(expected, packets);
}
-// TODO(http://crbug.com/651246) this test is flaky.
TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
- DISABLED_PacketCounterForMixedPacketTypesTest) {
+ PacketCounterForMixedPacketTypesTest) {
std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator> generator =
BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance();
@@ -245,9 +238,8 @@ TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
EXPECT_EQ(2, GetCounterFromHeader(packet[0]));
}
-// TODO(http://crbug.com/651246) this test is flaky.
TEST_F(ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest,
- DISABLED_PacketCounterWrappedAroundTest) {
+ PacketCounterWrappedAroundTest) {
std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator> generator =
BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance();

Powered by Google App Engine
This is Rietveld 408576698