Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2574833003: Roll src/third_party/pdfium/ 974b4a6c4..a9caab94c (2 commits). (Closed)

Created:
4 years ago by pdfium-deps-roller
Modified:
4 years ago
Reviewers:
dsinclair
CC:
chromium-reviews, dsinclair
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/pdfium/ 974b4a6c4..a9caab94c (2 commits). https://pdfium.googlesource.com/pdfium.git/+log/974b4a6c4bce..a9caab94c1f1 $ git log 974b4a6c4..a9caab94c --date=short --no-merges --format='%ad %ae %s' 2016-12-14 tsepez Avoid the ptr.reset(new XXX()) anti-pattern 2016-12-14 dsinclair Verify precision length before converting to string. BUG=673336 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Committed: https://crrev.com/d44f4e2d1968eba9b3f9bd15f5cc2f5d39deddbf Cr-Commit-Position: refs/heads/master@{#438517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
pdfium-deps-roller
4 years ago (2016-12-14 13:57:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574833003/1
4 years ago (2016-12-14 13:58:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 15:12:56 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-14 15:15:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d44f4e2d1968eba9b3f9bd15f5cc2f5d39deddbf
Cr-Commit-Position: refs/heads/master@{#438517}

Powered by Google App Engine
This is Rietveld 408576698