Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2574803003:
Remove unused icon references from webui cookie view. (Closed)
|
Created:
4 years ago by Evan Stade Modified:
4 years ago Reviewers:
dschuyler CC:
chromium-reviews, Dan Beam Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unused icon references from webui cookie view.
I couldn't find where in the code these were used and I couldn't find
them in the UI either ( chrome://settings/cookies ). I tried without
success to sleuth out when, if ever, these were actually used. js
lists don't show icons the way js trees do.
BUG=522168
Committed: https://crrev.com/d16b926c5cca5c860bba103a3c591946ad3cf88d
Cr-Commit-Position: refs/heads/master@{#438990}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 24 (14 generated)
estade@chromium.org changed reviewers: + dbeam@chromium.org
Description was changed from ========== Remove unused icon references from webui cookie view. I couldn't find where in the code these were used and I couldn't find them in the UI either ( chrome://settings/cookies ). I tried without success to sleuth out when, if ever, these were actually used. js lists don't show icons the way js trees do. BUG=522168 ========== to ========== Remove unused icon references from webui cookie view. I couldn't find where in the code these were used and I couldn't find them in the UI either ( chrome://settings/cookies ). I tried without success to sleuth out when, if ever, these were actually used. js lists don't show icons the way js trees do. BUG=522168 ==========
dbeam@chromium.org changed reviewers: + dschuyler@chromium.org
+dschuyler@
dbeam@chromium.org changed reviewers: - dbeam@chromium.org
The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2574803003/diff/1/chrome/browser/ui/webui/coo... File chrome/browser/ui/webui/cookies_tree_model_util.cc (left): https://codereview.chromium.org/2574803003/diff/1/chrome/browser/ui/webui/coo... chrome/browser/ui/webui/cookies_tree_model_util.cc:136: dict->SetString(kKeyIcon, "chrome://theme/IDR_COOKIE_STORAGE_ICON"); Are there associated icon resources that could be removed? It looks like this icon might be used elsewhere, but if you didn't find it anywhere when you were looking -- are the other references in this search also dead? https://cs.chromium.org/search/?q=IDR_COOKIE_STORAGE_ICON&sq=package:chromium...
On 2016/12/15 02:24:48, dschuyler wrote: > https://codereview.chromium.org/2574803003/diff/1/chrome/browser/ui/webui/coo... > File chrome/browser/ui/webui/cookies_tree_model_util.cc (left): > > https://codereview.chromium.org/2574803003/diff/1/chrome/browser/ui/webui/coo... > chrome/browser/ui/webui/cookies_tree_model_util.cc:136: > dict->SetString(kKeyIcon, "chrome://theme/IDR_COOKIE_STORAGE_ICON"); > Are there associated icon resources that could be removed? > > It looks like this icon might be used elsewhere, but if you didn't find it > anywhere when you were looking -- are the other references in this search also > dead? > https://cs.chromium.org/search/?q=IDR_COOKIE_STORAGE_ICON&sq=package:chromium... it's still used elsewhere and I've filed a bug to remove it. You can see it in the collected cookies view when a site uses session storage.
lgtm
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481847106248800, "parent_rev":
"d5d6042d6291a0171b0ae8dec0035887c7635905", "commit_rev":
"ee9bf9770996c68b1ae1167a99b72ebbed2fd958"}
Message was sent while issue was closed.
Description was changed from ========== Remove unused icon references from webui cookie view. I couldn't find where in the code these were used and I couldn't find them in the UI either ( chrome://settings/cookies ). I tried without success to sleuth out when, if ever, these were actually used. js lists don't show icons the way js trees do. BUG=522168 ========== to ========== Remove unused icon references from webui cookie view. I couldn't find where in the code these were used and I couldn't find them in the UI either ( chrome://settings/cookies ). I tried without success to sleuth out when, if ever, these were actually used. js lists don't show icons the way js trees do. BUG=522168 Review-Url: https://codereview.chromium.org/2574803003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove unused icon references from webui cookie view. I couldn't find where in the code these were used and I couldn't find them in the UI either ( chrome://settings/cookies ). I tried without success to sleuth out when, if ever, these were actually used. js lists don't show icons the way js trees do. BUG=522168 Review-Url: https://codereview.chromium.org/2574803003 ========== to ========== Remove unused icon references from webui cookie view. I couldn't find where in the code these were used and I couldn't find them in the UI either ( chrome://settings/cookies ). I tried without success to sleuth out when, if ever, these were actually used. js lists don't show icons the way js trees do. BUG=522168 Committed: https://crrev.com/d16b926c5cca5c860bba103a3c591946ad3cf88d Cr-Commit-Position: refs/heads/master@{#438990} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d16b926c5cca5c860bba103a3c591946ad3cf88d Cr-Commit-Position: refs/heads/master@{#438990} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
