Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp

Issue 2574773002: Migrate WTF::Vector::append() to ::push_back() [part 4 of N] (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp
index fc29919a4581b42bd611afbb52c653def293ba2a..788812d95a06395d503d8288049a7609f6f26796 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp
@@ -219,7 +219,7 @@ class LogUpgradeDefinition : public TestCustomElementDefinition {
}
bool runConstructor(Element* element) override {
- m_logs.append(Constructor);
+ m_logs.push_back(Constructor);
m_element = element;
return TestCustomElementDefinition::runConstructor(element);
}
@@ -229,30 +229,30 @@ class LogUpgradeDefinition : public TestCustomElementDefinition {
bool hasAdoptedCallback() const override { return true; }
void runConnectedCallback(Element* element) override {
- m_logs.append(ConnectedCallback);
+ m_logs.push_back(ConnectedCallback);
EXPECT_EQ(element, m_element);
}
void runDisconnectedCallback(Element* element) override {
- m_logs.append(DisconnectedCallback);
+ m_logs.push_back(DisconnectedCallback);
EXPECT_EQ(element, m_element);
}
void runAdoptedCallback(Element* element,
Document* oldOwner,
Document* newOwner) override {
- m_logs.append(AdoptedCallback);
+ m_logs.push_back(AdoptedCallback);
EXPECT_EQ(element, m_element);
- m_adopted.append(new Adopted(oldOwner, newOwner));
+ m_adopted.push_back(new Adopted(oldOwner, newOwner));
}
void runAttributeChangedCallback(Element* element,
const QualifiedName& name,
const AtomicString& oldValue,
const AtomicString& newValue) override {
- m_logs.append(AttributeChangedCallback);
+ m_logs.push_back(AttributeChangedCallback);
EXPECT_EQ(element, m_element);
- m_attributeChanged.append(AttributeChanged{name, oldValue, newValue});
+ m_attributeChanged.push_back(AttributeChanged{name, oldValue, newValue});
}
};

Powered by Google App Engine
This is Rietveld 408576698