Remove chrome-extension-resource:// scheme

Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=674272
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26
Cr-Commit-Position: refs/heads/master@{#439182}

[ncarter (slow), 2016-12-13 21:12:30]

Description was changed from

==========
ne# Enter a description of the change.
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=
==========

to

==========
ne# Enter a description of the change.
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ncarter (slow), 2016-12-13 21:12:55]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 21:13:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 22:16:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:16:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ncarter (slow), 2016-12-13 22:27:17]

Description was changed from

==========
ne# Enter a description of the change.
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ncarter (slow), 2016-12-14 19:43:24]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 19:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-12-14 20:07:56]

nick@chromium.org changed reviewers:
+ jamescook@chromium.org, rdevlin.cronin@chromium.org

[ncarter (slow), 2016-12-14 20:07:57]

James, Devlin:

I've convinced myself that this removal is safe because there's no code to
create the DIR_RESOURCES_EXTENSION anywhere that I can find, and it doesn't
appear to be created by the installer.

However, I'm still struggling to figure out exactly when this code became unused
-- because I have no idea what chrome-extension-resource:// ever was supposed to
do. Was it about export/import directives in chrome apps? Was it for packaged
extensions?

Can you help me figure out the story?

[Devlin, 2016-12-14 20:17:55]

On 2016/12/14 20:07:57, ncarter wrote:
> James, Devlin:
> 
> I've convinced myself that this removal is safe because there's no code to
> create the DIR_RESOURCES_EXTENSION anywhere that I can find, and it doesn't
> appear to be created by the installer.
> 
> However, I'm still struggling to figure out exactly when this code became
unused
> -- because I have no idea what chrome-extension-resource:// ever was supposed
to
> do. Was it about export/import directives in chrome apps? Was it for packaged
> extensions?
> 
> Can you help me figure out the story?

+asargent to cc in case he has more info.

Thanks for doing this, Nick!  I'll take a look this afternoon.  In the meantime,
here's what I've managed to dig up:
It looks like chrome-extension-resource was originally intended as a way to
serve extension resources for platform apps, but it looks like this was as far
as it ever got.  It was added in https://chromiumcodereview.appspot.com/9909019
for crbug.com/122987, but then no progress was ever made on that bug.  So to me
- sounds like a bunch of dead code that we've been toting around for far too
long. :)

[James Cook, 2016-12-14 20:41:50]

I don't have much to add here. When I worked on app_shell I suspect I just
cargo-culted the code. I'll let you work out with Devlin and Antony whether it's
safe to remove.

If so, //extensions/shell lgtm with nits

https://codereview.chromium.org/2574763003/diff/20001/extensions/shell/common...
File extensions/shell/common/shell_content_client.cc (right):

https://codereview.chromium.org/2574763003/diff/20001/extensions/shell/common...
extensions/shell/common/shell_content_client.cc:77: static const
url::SchemeWithType kShellStandardURLSchemes[] = {
nit: eliminate this and the iteration below, just add the one item directly

https://codereview.chromium.org/2574763003/diff/20001/extensions/test/extensi...
File extensions/test/extensions_unittests_main.cc (right):

https://codereview.chromium.org/2574763003/diff/20001/extensions/test/extensi...
extensions/test/extensions_unittests_main.cc:26: const url::SchemeWithType
kExtensionStandardURLSchemes[] = {
ditto

[ncarter (slow), 2016-12-14 20:57:52]

Description was changed from

==========
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=674272
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-14 21:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 21:03:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[asargent_no_longer_on_chrome, 2016-12-14 21:18:00]

On 2016/12/14 20:17:55, Devlin wrote:
> On 2016/12/14 20:07:57, ncarter wrote:
> > James, Devlin:
> > 
> > I've convinced myself that this removal is safe because there's no code to
> > create the DIR_RESOURCES_EXTENSION anywhere that I can find, and it doesn't
> > appear to be created by the installer.
> > 
> > However, I'm still struggling to figure out exactly when this code became
> unused
> > -- because I have no idea what chrome-extension-resource:// ever was
supposed
> to
> > do. Was it about export/import directives in chrome apps? Was it for
packaged
> > extensions?
> > 
> > Can you help me figure out the story?
> 
> +asargent to cc in case he has more info.
> 
> Thanks for doing this, Nick!  I'll take a look this afternoon.  In the
meantime,
> here's what I've managed to dig up:
> It looks like chrome-extension-resource was originally intended as a way to
> serve extension resources for platform apps, but it looks like this was as far
> as it ever got.  It was added in
https://chromiumcodereview.appspot.com/9909019
> for crbug.com/122987, but then no progress was ever made on that bug.  So to
me
> - sounds like a bunch of dead code that we've been toting around for far too
> long. :)

Yep, I think this is ok to remove as far as I can recall.

[ncarter (slow), 2016-12-14 22:23:46]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:24:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-12-14 22:26:41]

https://codereview.chromium.org/2574763003/diff/20001/extensions/shell/common...
File extensions/shell/common/shell_content_client.cc (right):

https://codereview.chromium.org/2574763003/diff/20001/extensions/shell/common...
extensions/shell/common/shell_content_client.cc:77: static const
url::SchemeWithType kShellStandardURLSchemes[] = {
On 2016/12/14 20:41:49, James Cook wrote:
> nit: eliminate this and the iteration below, just add the one item directly

Done.

https://codereview.chromium.org/2574763003/diff/20001/extensions/test/extensi...
File extensions/test/extensions_unittests_main.cc (right):

https://codereview.chromium.org/2574763003/diff/20001/extensions/test/extensi...
extensions/test/extensions_unittests_main.cc:26: const url::SchemeWithType
kExtensionStandardURLSchemes[] = {
On 2016/12/14 20:41:50, James Cook wrote:
> ditto

Done.

[ncarter (slow), 2016-12-14 22:26:42]

https://codereview.chromium.org/2574763003/diff/20001/extensions/shell/common...
File extensions/shell/common/shell_content_client.cc (right):

https://codereview.chromium.org/2574763003/diff/20001/extensions/shell/common...
extensions/shell/common/shell_content_client.cc:77: static const
url::SchemeWithType kShellStandardURLSchemes[] = {
On 2016/12/14 20:41:49, James Cook wrote:
> nit: eliminate this and the iteration below, just add the one item directly

Done.

https://codereview.chromium.org/2574763003/diff/20001/extensions/test/extensi...
File extensions/test/extensions_unittests_main.cc (right):

https://codereview.chromium.org/2574763003/diff/20001/extensions/test/extensi...
extensions/test/extensions_unittests_main.cc:26: const url::SchemeWithType
kExtensionStandardURLSchemes[] = {
On 2016/12/14 20:41:50, James Cook wrote:
> ditto

Done.

[ncarter (slow), 2016-12-14 22:40:27]

On 2016/12/14 22:26:42, ncarter wrote:
>
https://codereview.chromium.org/2574763003/diff/20001/extensions/shell/common...
> File extensions/shell/common/shell_content_client.cc (right):
> 
>
https://codereview.chromium.org/2574763003/diff/20001/extensions/shell/common...
> extensions/shell/common/shell_content_client.cc:77: static const
> url::SchemeWithType kShellStandardURLSchemes[] = {
> On 2016/12/14 20:41:49, James Cook wrote:
> > nit: eliminate this and the iteration below, just add the one item directly
> 
> Done.
> 
>
https://codereview.chromium.org/2574763003/diff/20001/extensions/test/extensi...
> File extensions/test/extensions_unittests_main.cc (right):
> 
>
https://codereview.chromium.org/2574763003/diff/20001/extensions/test/extensi...
> extensions/test/extensions_unittests_main.cc:26: const url::SchemeWithType
> kExtensionStandardURLSchemes[] = {
> On 2016/12/14 20:41:50, James Cook wrote:
> > ditto
> 
> Done.

devlin: ptal

[Devlin, 2016-12-14 23:38:18]

woo!  LGTM

[commit-bot: I haz the power, 2016-12-14 23:47:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:47:51]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2016-12-16 00:24:03]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2016-12-16 00:24:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2574763003/#ps60001
(title: "resolve jamescook suggestions")

[commit-bot: I haz the power, 2016-12-16 00:24:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 01:37:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:37:25]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ncarter (slow), 2016-12-16 17:50:07]

nick@chromium.org changed reviewers:
+ sky@chromium.org

[ncarter (slow), 2016-12-16 17:50:08]

sky: please review chrome/

[ncarter (slow), 2016-12-16 18:01:46]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 18:02:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-12-16 18:24:15]

The non-extension chrome/ files LGTM (I'm assuming devlin@ reviewed them as he
is an extensions owner)

[ncarter (slow), 2016-12-16 19:27:27]

nick@chromium.org changed reviewers:
+ scottmg@chromium.org

[ncarter (slow), 2016-12-16 19:27:28]

+scottmg for root /BUILD.gn

[scottmg, 2016-12-16 19:47:31]

lgtm

[commit-bot: I haz the power, 2016-12-16 19:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 19:59:48]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2016-12-16 20:02:09]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2016-12-16 20:02:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2574763003/#ps100001
(title: "Remove BUILD reference to resources/extension outdir.")

[commit-bot: I haz the power, 2016-12-16 20:03:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 20:52:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481918529187090,
"parent_rev": "7c304b0be8cd62f0e737570c2d85a55b9976a641", "commit_rev":
"170d96484d5b979ded630872d3c5a28429165cae"}

[commit-bot: I haz the power, 2016-12-16 20:52:42]

Description was changed from

==========
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=674272
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=674272
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2574763003
==========

[commit-bot: I haz the power, 2016-12-16 20:53:02]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-16 20:57:14]

Description was changed from

==========
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=674272
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2574763003
==========

to

==========
Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG=674272
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26
Cr-Commit-Position: refs/heads/master@{#439182}
==========

[commit-bot: I haz the power, 2016-12-16 20:57:16]

Patchset 6 (id:??) landed as
https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26
Cr-Commit-Position: refs/heads/master@{#439182}