Removes ScopedVector from presentation_service_impl.

Removes ScopedVector from presentation_service_impl.

Removes ScopedVector in favor of vector<unique_ptr>  in presentation_service_impl and related files as requested in Avi's
comment in https://codereview.chromium.org/2562603002/

BUG=554289
Committed: https://crrev.com/1014cd6bdcd0d8dc3675c5e77eeeafce7cf98e46
Cr-Commit-Position: refs/heads/master@{#439052}

[CJ, 2016-12-13 04:24:52]

lethalantidote@chromium.org changed reviewers:
+ avi@chromium.org

[CJ, 2016-12-13 04:24:53]

Please take a look.

[Avi (use Gerrit), 2016-12-13 04:45:31]

Change your CL's description to be something like

"Removes ScopedVector from xxxxx".

This isn't removing it entirely :)

https://codereview.chromium.org/2574673002/diff/1/content/browser/presentatio...
File content/browser/presentation/presentation_service_impl.cc (right):

https://codereview.chromium.org/2574673002/diff/1/content/browser/presentatio...
content/browser/presentation/presentation_service_impl.cc:473: for (size_t i =
0; i < messages.size(); i++) {
for (const auto& message : messages)

?

Also, why not a std::transform? You might be able to just change the parameter
type to

const std::unique_ptr<PresentationSessionMessage>&

[CJ, 2016-12-13 22:14:00]

Description was changed from

==========
Removes ScopedVector.

Removes ScopedVector in favor of vector<unique_ptr> as requested in Avi's
comment in https://codereview.chromium.org/2562603002/

BUG=554289
==========

to

==========
Removes ScopedVector from presentation_service_impl.

Removes ScopedVector in favor of vector<unique_ptr>  in
presentation_service_impl and related files as requested in Avi's
comment in https://codereview.chromium.org/2562603002/

BUG=554289
==========

[CJ, 2016-12-13 23:01:31]

https://codereview.chromium.org/2574673002/diff/1/content/browser/presentatio...
File content/browser/presentation/presentation_service_impl.cc (right):

https://codereview.chromium.org/2574673002/diff/1/content/browser/presentatio...
content/browser/presentation/presentation_service_impl.cc:473: for (size_t i =
0; i < messages.size(); i++) {
On 2016/12/13 04:45:31, Avi wrote:
> for (const auto& message : messages)
> 
> ?
> 
> Also, why not a std::transform? You might be able to just change the parameter
> type to
> 
> const std::unique_ptr<PresentationSessionMessage>&

Done.

Was having a hard time getting it to compile. Missed the const &, so it kept
blowing up.

[Avi (use Gerrit), 2016-12-14 03:32:09]

LGTM with fix.

https://codereview.chromium.org/2574673002/diff/20001/content/browser/present...
File content/browser/presentation/presentation_service_impl.cc (right):

https://codereview.chromium.org/2574673002/diff/20001/content/browser/present...
content/browser/presentation/presentation_service_impl.cc:476: //}
Don't commit commented-out code.

[CJ, 2016-12-14 19:56:13]

https://codereview.chromium.org/2574673002/diff/20001/content/browser/present...
File content/browser/presentation/presentation_service_impl.cc (right):

https://codereview.chromium.org/2574673002/diff/20001/content/browser/present...
content/browser/presentation/presentation_service_impl.cc:476: //}
On 2016/12/14 03:32:09, Avi wrote:
> Don't commit commented-out code.

Done.

[CJ, 2016-12-14 19:56:32]

The CQ bit was checked by lethalantidote@chromium.org

[CJ, 2016-12-14 19:56:32]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2574673002/#ps40001
(title: "Merge branch 'real_master' into noscope")

[commit-bot: I haz the power, 2016-12-14 19:57:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:08:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:08:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[CJ, 2016-12-14 20:45:39]

lethalantidote@chromium.org changed reviewers:
+ imcheng@chromium.org

[CJ, 2016-12-14 20:45:39]

+imcheng, owners, presentation_service_delegate_impl.cc

[imcheng, 2016-12-15 18:59:05]

lgtm

[CJ, 2016-12-15 22:13:11]

The CQ bit was checked by lethalantidote@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:13:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 22:33:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 22:33:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[CJ, 2016-12-15 22:49:47]

The CQ bit was checked by lethalantidote@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:50:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 01:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:17:07]

Dry run: This issue passed the CQ dry run.

[CJ, 2016-12-16 06:45:58]

The CQ bit was checked by lethalantidote@chromium.org

[CJ, 2016-12-16 06:45:58]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2574673002/#ps60001
(title: "Fixes test.")

[commit-bot: I haz the power, 2016-12-16 06:46:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 06:59:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481870758371470,
"parent_rev": "470a2fc78b051b32b7987f262b7360405947e6a9", "commit_rev":
"55193785ad5c2b79504e1194132f8319900e1cb3"}

[commit-bot: I haz the power, 2016-12-16 07:00:13]

Description was changed from

==========
Removes ScopedVector from presentation_service_impl.

Removes ScopedVector in favor of vector<unique_ptr>  in
presentation_service_impl and related files as requested in Avi's
comment in https://codereview.chromium.org/2562603002/

BUG=554289
==========

to

==========
Removes ScopedVector from presentation_service_impl.

Removes ScopedVector in favor of vector<unique_ptr>  in
presentation_service_impl and related files as requested in Avi's
comment in https://codereview.chromium.org/2562603002/

BUG=554289

Review-Url: https://codereview.chromium.org/2574673002
==========

[commit-bot: I haz the power, 2016-12-16 07:00:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-16 07:01:49]

Description was changed from

==========
Removes ScopedVector from presentation_service_impl.

Removes ScopedVector in favor of vector<unique_ptr>  in
presentation_service_impl and related files as requested in Avi's
comment in https://codereview.chromium.org/2562603002/

BUG=554289

Review-Url: https://codereview.chromium.org/2574673002
==========

to

==========
Removes ScopedVector from presentation_service_impl.

Removes ScopedVector in favor of vector<unique_ptr>  in
presentation_service_impl and related files as requested in Avi's
comment in https://codereview.chromium.org/2562603002/

BUG=554289

Committed: https://crrev.com/1014cd6bdcd0d8dc3675c5e77eeeafce7cf98e46
Cr-Commit-Position: refs/heads/master@{#439052}
==========

[commit-bot: I haz the power, 2016-12-16 07:01:50]

Patchset 4 (id:??) landed as
https://crrev.com/1014cd6bdcd0d8dc3675c5e77eeeafce7cf98e46
Cr-Commit-Position: refs/heads/master@{#439052}