Service Manager: Override DLL search path when launching services in component builds

Service Manager: Override DLL search path when launching services in component builds

Service executables don't live alongside other build artifacts, so in component builds
Windows doesn't normally know where to look for them at runtime. This overrides the
DLL search path temporarily before launching any service child process.

BUG=None
R=ben@chromium.org

Committed: https://crrev.com/386c2e2e5d37dba2144029fc990faeedf35733a2
Cr-Commit-Position: refs/heads/master@{#438086}

[Ken Rockot(use gerrit already), 2016-12-13 02:46:13]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 02:46:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-13 02:48:58]

This at least fixes the DLL loading error. I don't know what I can run on
Windows now to do a real end-to-end local test. Is there some useful test
service that covers what you want?

I assume it's intentional that mash_session no longer works.

[Ben Goodger (Google), 2016-12-13 02:51:22]

lgtm

I've been running

mojo_runner --service=mash_session --use-test-config --window-manager=simple_wm

[commit-bot: I haz the power, 2016-12-13 03:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 03:21:11]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ken Rockot(use gerrit already), 2016-12-13 04:09:05]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 04:09:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 05:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 05:51:33]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-12-13 06:48:44]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-13 06:48:45]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2574653002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-12-13 06:49:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 06:53:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481611724916600,
"parent_rev": "71f8c0049c28a7d914ae56c82e76e1d6f3b8f09e", "commit_rev":
"f041e19ccad037c4ee64fd036598f78a4c50687c"}

[commit-bot: I haz the power, 2016-12-13 06:53:40]

Description was changed from

==========
Service Manager: Override DLL search path when launching services in component
builds

Service executables don't live alongside other build artifacts, so in component
builds
Windows doesn't normally know where to look for them at runtime. This overrides
the
DLL search path temporarily before launching any service child process.

BUG=None
R=ben@chromium.org
==========

to

==========
Service Manager: Override DLL search path when launching services in component
builds

Service executables don't live alongside other build artifacts, so in component
builds
Windows doesn't normally know where to look for them at runtime. This overrides
the
DLL search path temporarily before launching any service child process.

BUG=None
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2574653002
==========

[commit-bot: I haz the power, 2016-12-13 06:53:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 06:56:20]

Description was changed from

==========
Service Manager: Override DLL search path when launching services in component
builds

Service executables don't live alongside other build artifacts, so in component
builds
Windows doesn't normally know where to look for them at runtime. This overrides
the
DLL search path temporarily before launching any service child process.

BUG=None
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2574653002
==========

to

==========
Service Manager: Override DLL search path when launching services in component
builds

Service executables don't live alongside other build artifacts, so in component
builds
Windows doesn't normally know where to look for them at runtime. This overrides
the
DLL search path temporarily before launching any service child process.

BUG=None
R=ben@chromium.org

Committed: https://crrev.com/386c2e2e5d37dba2144029fc990faeedf35733a2
Cr-Commit-Position: refs/heads/master@{#438086}
==========

[commit-bot: I haz the power, 2016-12-13 06:56:20]

Patchset 2 (id:??) landed as
https://crrev.com/386c2e2e5d37dba2144029fc990faeedf35733a2
Cr-Commit-Position: refs/heads/master@{#438086}