Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2574633002:
Don't use gtk2 instrumented library when using gtk3 (Closed)
|
Created:
4 years ago by Tom (Use chromium acct) Modified:
3 years, 11 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't use gtk2 instrumented library when using gtk3
BUG=668446
TBR=glider@chromium.org
Review-Url: https://codereview.chromium.org/2574633002
Cr-Commit-Position: refs/heads/master@{#442150}
Committed: https://chromium.googlesource.com/chromium/src/+/c48bc79acb2ed96e2f71856c01b57ce369681ba7
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
thomasanderson@google.com changed reviewers: + glider@chromium.org
glider@ PTAL I tried adding a gtk3 instrumented library but was unsuccessful. Every time I tried to do even basic things I would get msan errors
On 2016/12/13 01:39:41, Tom Anderson wrote: > glider@ PTAL > > I tried adding a gtk3 instrumented library but was unsuccessful. Every time I > tried to do even basic things I would get msan errors Rubberstamp LGTM
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
pinging glider@. Can you lgtm from your chromium account?
thomasanderson@chromium.org changed reviewers: + thomasanderson@chromium.org
The CQ bit was checked by thomasanderson@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Don't use gtk2 instrumented library when using gtk3 BUG=668446 ========== to ========== Don't use gtk2 instrumented library when using gtk3 BUG=668446 TBR=glider@chromium.org ==========
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1483758122193880, "parent_rev":
"78357e64419e215213610a27cd89a94da49e6bbe", "commit_rev":
"c48bc79acb2ed96e2f71856c01b57ce369681ba7"}
Message was sent while issue was closed.
Description was changed from ========== Don't use gtk2 instrumented library when using gtk3 BUG=668446 TBR=glider@chromium.org ========== to ========== Don't use gtk2 instrumented library when using gtk3 BUG=668446 TBR=glider@chromium.org Review-Url: https://codereview.chromium.org/2574633002 Cr-Commit-Position: refs/heads/master@{#442150} Committed: https://chromium.googlesource.com/chromium/src/+/c48bc79acb2ed96e2f71856c01b5... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c48bc79acb2ed96e2f71856c01b5... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
