third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h - Issue 2574593003: Fix Windows build warning LNK4217 for blink_platform.dll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h

Issue 2574593003: Fix Windows build warning LNK4217 for blink_platform.dll. (Closed)

Patch Set: Do not export geometry struct traits from blink_platform.dll Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h

diff --git a/third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h b/third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h

index 42afd6604329b13a79a26d14450246c672bb102a..7d7cb01039e12b353f39525a0aa977dcfb643ecd 100644

--- a/third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h

+++ b/third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h

@@ -5,14 +5,12 @@

#ifndef GeometryStructTraits_h

#define GeometryStructTraits_h

-#include "platform/PlatformExport.h"

#include "ui/gfx/geometry/mojo/geometry.mojom-blink.h"

namespace mojo {

template <>

-struct PLATFORM_EXPORT

- StructTraits<gfx::mojom::blink::Size::DataView, ::blink::WebSize> {

+struct StructTraits<gfx::mojom::blink::Size::DataView, ::blink::WebSize> {

static int width(const ::blink::WebSize& size) { return size.width; }

static int height(const ::blink::WebSize& size) { return size.height; }

static bool Read(gfx::mojom::blink::Size::DataView, ::blink::WebSize* out);