third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h - Issue 2574593003: Fix Windows build warning LNK4217 for blink_platform.dll.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h

Issue 2574593003: Fix Windows build warning LNK4217 for blink_platform.dll. (Closed)

Patch Set: Do not export geometry struct traits from blink_platform.dll Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef GeometryStructTraits_h	5 #ifndef GeometryStructTraits_h

6 #define GeometryStructTraits_h	6 #define GeometryStructTraits_h

7	7

8 #include "platform/PlatformExport.h"

9 #include "ui/gfx/geometry/mojo/geometry.mojom-blink.h"	8 #include "ui/gfx/geometry/mojo/geometry.mojom-blink.h"

10	9

11 namespace mojo {	10 namespace mojo {

12	11

13 template <>	12 template <>

14 struct PLATFORM_EXPORT	13 struct StructTraits<gfx::mojom::blink::Size::DataView, ::blink::WebSize> {

15 StructTraits<gfx::mojom::blink::Size::DataView, ::blink::WebSize> {

16 static int width(const ::blink::WebSize& size) { return size.width; }	14 static int width(const ::blink::WebSize& size) { return size.width; }

17 static int height(const ::blink::WebSize& size) { return size.height; }	15 static int height(const ::blink::WebSize& size) { return size.height; }

18 static bool Read(gfx::mojom::blink::Size::DataView, ::blink::WebSize* out);	16 static bool Read(gfx::mojom::blink::Size::DataView, ::blink::WebSize* out);

19 };	17 };

20	18

21 } // namespace mojo	19 } // namespace mojo

22	20

23 #endif // GeometryStructTraits_h	21 #endif // GeometryStructTraits_h

OLD	NEW