Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2574593002: Revert of android: Increase NUM_PRIVILEGED_SERVICES to 20 (Closed)

Created:
4 years ago by boliu
Modified:
4 years ago
Reviewers:
Ted C, halliwell, Simeon, AndyWu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, halliwell+watch_chromium.org, agrieve+watch_chromium.org, alokp+watch_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Increase NUM_PRIVILEGED_SERVICES to 20 (patchset #3 id:40001 of https://codereview.chromium.org/2555303004/ ) Reason for revert: Android keeps the intent for a long time, so randomize doesn't help at all. More details: crbug.com/664341#c91 Original issue's description: > android: Increase NUM_PRIVILEGED_SERVICES to 20 > > This works in conjunction with > https://codereview.chromium.org/2557273004/ to workaround > crbug.com/664341. That CL ramdomizes the order of the named services to > avoid collision, which is not actually effective unless there is a large > number of named services to choose from. > > Sandboxed service already has 20 named services, so up the privileged > (gpu) count to 20 as well. > > BUG=664341 > > Committed: https://crrev.com/9b853cfcf82d8c57487cb0dd8d1eeaa5ca40260f > Cr-Commit-Position: refs/heads/master@{#437634} TBR=tedchoc@chromium.org,halliwell@chromium.org,sanfin@chromium.org,tsunghung@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=664341 Committed: https://crrev.com/79b0e6bde76242fd5f94ef47a68525f5247c9824 Cr-Commit-Position: refs/heads/master@{#437997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -247 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/android/apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M components/test/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService0.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService1.java View 1 chunk +1 line, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService10.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService11.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService12.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService13.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService14.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService15.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService16.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService17.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService18.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService19.java View 1 chunk +0 lines, -13 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService2.java View 1 chunk +1 line, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService3.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService4.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService5.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService6.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService7.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService8.java View 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/PrivilegedProcessService9.java View 1 chunk +0 lines, -13 lines 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/linker_test_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
boliu
Created Revert of android: Increase NUM_PRIVILEGED_SERVICES to 20
4 years ago (2016-12-13 00:45:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574593002/1
4 years ago (2016-12-13 00:46:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 02:45:49 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 02:48:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79b0e6bde76242fd5f94ef47a68525f5247c9824
Cr-Commit-Position: refs/heads/master@{#437997}

Powered by Google App Engine
This is Rietveld 408576698