Description was changed from
==========
Revert of android: Increase NUM_PRIVILEGED_SERVICES to 20 (patchset #3 id:40001
of https://codereview.chromium.org/2555303004/ )
Reason for revert:
Android keeps the intent for a long time, so
randomize doesn't help at all. More details:
crbug.com/664341#c91
Original issue's description:
> android: Increase NUM_PRIVILEGED_SERVICES to 20
>
> This works in conjunction with
> https://codereview.chromium.org/2557273004/ to workaround
> crbug.com/664341. That CL ramdomizes the order of the named services to
> avoid collision, which is not actually effective unless there is a large
> number of named services to choose from.
>
> Sandboxed service already has 20 named services, so up the privileged
> (gpu) count to 20 as well.
>
> BUG=664341
>
> Committed: https://crrev.com/9b853cfcf82d8c57487cb0dd8d1eeaa5ca40260f
> Cr-Commit-Position: refs/heads/master@{#437634}
TBR=tedchoc@chromium.org,halliwell@chromium.org,sanfin@chromium.org,tsunghung...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664341
==========
to
==========
Revert of android: Increase NUM_PRIVILEGED_SERVICES to 20 (patchset #3 id:40001
of https://codereview.chromium.org/2555303004/ )
Reason for revert:
Android keeps the intent for a long time, so
randomize doesn't help at all. More details:
crbug.com/664341#c91
Original issue's description:
> android: Increase NUM_PRIVILEGED_SERVICES to 20
>
> This works in conjunction with
> https://codereview.chromium.org/2557273004/ to workaround
> crbug.com/664341. That CL ramdomizes the order of the named services to
> avoid collision, which is not actually effective unless there is a large
> number of named services to choose from.
>
> Sandboxed service already has 20 named services, so up the privileged
> (gpu) count to 20 as well.
>
> BUG=664341
>
> Committed: https://crrev.com/9b853cfcf82d8c57487cb0dd8d1eeaa5ca40260f
> Cr-Commit-Position: refs/heads/master@{#437634}
TBR=tedchoc@chromium.org,halliwell@chromium.org,sanfin@chromium.org,tsunghung...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664341
Review-Url: https://codereview.chromium.org/2574593002
==========
Description was changed from
==========
Revert of android: Increase NUM_PRIVILEGED_SERVICES to 20 (patchset #3 id:40001
of https://codereview.chromium.org/2555303004/ )
Reason for revert:
Android keeps the intent for a long time, so
randomize doesn't help at all. More details:
crbug.com/664341#c91
Original issue's description:
> android: Increase NUM_PRIVILEGED_SERVICES to 20
>
> This works in conjunction with
> https://codereview.chromium.org/2557273004/ to workaround
> crbug.com/664341. That CL ramdomizes the order of the named services to
> avoid collision, which is not actually effective unless there is a large
> number of named services to choose from.
>
> Sandboxed service already has 20 named services, so up the privileged
> (gpu) count to 20 as well.
>
> BUG=664341
>
> Committed: https://crrev.com/9b853cfcf82d8c57487cb0dd8d1eeaa5ca40260f
> Cr-Commit-Position: refs/heads/master@{#437634}
TBR=tedchoc@chromium.org,halliwell@chromium.org,sanfin@chromium.org,tsunghung...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664341
Review-Url: https://codereview.chromium.org/2574593002
==========
to
==========
Revert of android: Increase NUM_PRIVILEGED_SERVICES to 20 (patchset #3 id:40001
of https://codereview.chromium.org/2555303004/ )
Reason for revert:
Android keeps the intent for a long time, so
randomize doesn't help at all. More details:
crbug.com/664341#c91
Original issue's description:
> android: Increase NUM_PRIVILEGED_SERVICES to 20
>
> This works in conjunction with
> https://codereview.chromium.org/2557273004/ to workaround
> crbug.com/664341. That CL ramdomizes the order of the named services to
> avoid collision, which is not actually effective unless there is a large
> number of named services to choose from.
>
> Sandboxed service already has 20 named services, so up the privileged
> (gpu) count to 20 as well.
>
> BUG=664341
>
> Committed: https://crrev.com/9b853cfcf82d8c57487cb0dd8d1eeaa5ca40260f
> Cr-Commit-Position: refs/heads/master@{#437634}
TBR=tedchoc@chromium.org,halliwell@chromium.org,sanfin@chromium.org,tsunghung...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664341
Committed: https://crrev.com/79b0e6bde76242fd5f94ef47a68525f5247c9824
Cr-Commit-Position: refs/heads/master@{#437997}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/79b0e6bde76242fd5f94ef47a68525f5247c9824 Cr-Commit-Position: refs/heads/master@{#437997}
Issue 2574593002: Revert of android: Increase NUM_PRIVILEGED_SERVICES to 20
(Closed)
Created 4 years ago by boliu
Modified 4 years ago
Reviewers: Ted C, halliwell, Simeon, AndyWu
Base URL:
Comments: 0