Update logdog butler (cipd_package) to new revision.

Update logdog butler (cipd_package) to new revision.

For some bots, the git_revision of cipd_package is pinned to a
very old version (summer 2016). This causes issues when trying to
communicate with other systems expecting a newer version, and leads
to issues like:
Failed to start logdog: Missing project [LOGDOG_STREAM_PROJECT]

This CL updates the pinned revision number to a newer version,
suggested in the linked bug.

A better fix would probably be to pin this in a shared location,
making it simple to update all these at the same time, instead
of specifiying it once per target.

This CL was generated by running the following script:
git grep -l -e \
  'git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a' \
  -- "*.json" | \
  xargs sed -ie \
    's/git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a/git_revision:25755a2c316937ee44a6432163dc5e2f9c85cf58/'

BUG=670817
Committed: https://crrev.com/ada812f0132a04edc08ff0df2e63ee1b1a4d64f6
Cr-Commit-Position: refs/heads/master@{#438005}

[nyquist, 2016-12-12 21:59:28]

nyquist@chromium.org changed reviewers:
+ dpranke@chromium.org

[nyquist, 2016-12-12 21:59:28]

dpranke: PTAL

[ghost stip (do not use), 2016-12-12 22:11:33]

stip@chromium.org changed reviewers:
+ stip@chromium.org

[ghost stip (do not use), 2016-12-12 22:11:34]

lgtm

[Dirk Pranke, 2016-12-12 22:11:38]

lgtm. stip@, can you review also and confirm this matches up w/ dnj's comment in
https://bugs.chromium.org/p/chromium/issues/detail?id=670817#c6 ?

[nyquist, 2016-12-12 22:30:19]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2016-12-12 22:34:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:55:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481581819735290, "parent_rev":
"a74950b10a836e710b730691233cd85093e6625e", "commit_rev":
"c6b97d212ba54f0230a0d42dc265c06e79f16e33"}

[commit-bot: I haz the power, 2016-12-13 02:56:01]

Description was changed from

==========
Update logdog butler (cipd_package) to new revision.

For some bots, the git_revision of cipd_package is pinned to a
very old version (summer 2016). This causes issues when trying to
communicate with other systems expecting a newer version, and leads
to issues like:
Failed to start logdog: Missing project [LOGDOG_STREAM_PROJECT]

This CL updates the pinned revision number to a newer version,
suggested in the linked bug.

A better fix would probably be to pin this in a shared location,
making it simple to update all these at the same time, instead
of specifiying it once per target.

This CL was generated by running the following script:
git grep -l -e \
  'git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a' \
  -- "*.json" | \
  xargs sed -ie \
   
's/git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a/git_revision:25755a2c316937ee44a6432163dc5e2f9c85cf58/'

BUG=670817
==========

to

==========
Update logdog butler (cipd_package) to new revision.

For some bots, the git_revision of cipd_package is pinned to a
very old version (summer 2016). This causes issues when trying to
communicate with other systems expecting a newer version, and leads
to issues like:
Failed to start logdog: Missing project [LOGDOG_STREAM_PROJECT]

This CL updates the pinned revision number to a newer version,
suggested in the linked bug.

A better fix would probably be to pin this in a shared location,
making it simple to update all these at the same time, instead
of specifiying it once per target.

This CL was generated by running the following script:
git grep -l -e \
  'git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a' \
  -- "*.json" | \
  xargs sed -ie \
   
's/git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a/git_revision:25755a2c316937ee44a6432163dc5e2f9c85cf58/'

BUG=670817

Review-Url: https://codereview.chromium.org/2574563002
==========

[commit-bot: I haz the power, 2016-12-13 02:56:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 02:59:44]

Description was changed from

==========
Update logdog butler (cipd_package) to new revision.

For some bots, the git_revision of cipd_package is pinned to a
very old version (summer 2016). This causes issues when trying to
communicate with other systems expecting a newer version, and leads
to issues like:
Failed to start logdog: Missing project [LOGDOG_STREAM_PROJECT]

This CL updates the pinned revision number to a newer version,
suggested in the linked bug.

A better fix would probably be to pin this in a shared location,
making it simple to update all these at the same time, instead
of specifiying it once per target.

This CL was generated by running the following script:
git grep -l -e \
  'git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a' \
  -- "*.json" | \
  xargs sed -ie \
   
's/git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a/git_revision:25755a2c316937ee44a6432163dc5e2f9c85cf58/'

BUG=670817

Review-Url: https://codereview.chromium.org/2574563002
==========

to

==========
Update logdog butler (cipd_package) to new revision.

For some bots, the git_revision of cipd_package is pinned to a
very old version (summer 2016). This causes issues when trying to
communicate with other systems expecting a newer version, and leads
to issues like:
Failed to start logdog: Missing project [LOGDOG_STREAM_PROJECT]

This CL updates the pinned revision number to a newer version,
suggested in the linked bug.

A better fix would probably be to pin this in a shared location,
making it simple to update all these at the same time, instead
of specifiying it once per target.

This CL was generated by running the following script:
git grep -l -e \
  'git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a' \
  -- "*.json" | \
  xargs sed -ie \
   
's/git_revision:3ff24775a900b675866fbcacf2a8f98a18b2a16a/git_revision:25755a2c316937ee44a6432163dc5e2f9c85cf58/'

BUG=670817

Committed: https://crrev.com/ada812f0132a04edc08ff0df2e63ee1b1a4d64f6
Cr-Commit-Position: refs/heads/master@{#438005}
==========

[commit-bot: I haz the power, 2016-12-13 02:59:45]

Patchset 1 (id:??) landed as
https://crrev.com/ada812f0132a04edc08ff0df2e63ee1b1a4d64f6
Cr-Commit-Position: refs/heads/master@{#438005}

[Jamie Madill, 2016-12-14 21:10:04]

On 2016/12/13 02:59:45, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/ada812f0132a04edc08ff0df2e63ee1b1a4d64f6
> Cr-Commit-Position: refs/heads/master@{#438005}

This CL is missing the necessary change to the JSON generator for in
content/test/gpu/generate_buildbot_json.py, and subsequent changes to the GPU
bots will revert this change to gpu.fyi.json. I'm not sure if we can add a
comment or something to the JSON file to indicate it's a generated file, not a
hand-maintained one, but it's something to be mindful of. I think we'll handle
back-porting this.

[ynovikov, 2016-12-14 21:31:31]

On 2016/12/14 21:10:04, Jamie Madill wrote:
> On 2016/12/13 02:59:45, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/ada812f0132a04edc08ff0df2e63ee1b1a4d64f6
> > Cr-Commit-Position: refs/heads/master@{#438005}
> 
> This CL is missing the necessary change to the JSON generator for in
> content/test/gpu/generate_buildbot_json.py, and subsequent changes to the GPU
> bots will revert this change to gpu.fyi.json. I'm not sure if we can add a
> comment or something to the JSON file to indicate it's a generated file, not a
> hand-maintained one, but it's something to be mindful of. I think we'll handle
> back-porting this.

There is a comment on top of chromium.gpu.fyi.json:
  "AAAAA1 AUTOGENERATED FILE DO NOT EDIT": {},
  "AAAAA2 See generate_buildbot_json.py to make changes": {},

I've fixed generate_buildbot_json.py in
https://codereview.chromium.org/2577803002/

[ynovikov, 2016-12-14 22:24:42]

ynovikov@chromium.org changed reviewers:
+ kbr@chromium.org, ynovikov@chromium.org

[ynovikov, 2016-12-14 22:24:42]

I think the comment at the top of chromium.gpu.fyi.json is not noticeable
enough.
Maybe we should change the filename to something like
generated.chromium.gpu.fyi.json? Or put it in testing/buildbot/generated
directory?
Ken, what do you think?

[Dirk Pranke, 2016-12-14 22:58:59]

Bah, sorry, I should've caught that :(.

Can we add a presubmit that checks that if the generated files are modified,
they do in fact match what the generator would generate?

[nyquist, 2016-12-14 23:01:40]

On 2016/12/14 22:58:59, Dirk Pranke wrote:
> Bah, sorry, I should've caught that :(.
> 
> Can we add a presubmit that checks that if the generated files are modified,
> they do in fact match what the generator would generate?

Ouch. I'm sorry! :-(

What dpranke@ asks for sounds great though. That would help protect against
accidental changes like mine.

[Ken Russell (switch to Gerrit), 2016-12-20 06:44:18]

On 2016/12/14 23:01:40, nyquist (OOO back 1-3) wrote:
> On 2016/12/14 22:58:59, Dirk Pranke wrote:
> > Bah, sorry, I should've caught that :(.
> > 
> > Can we add a presubmit that checks that if the generated files are modified,
> > they do in fact match what the generator would generate?
> 
> Ouch. I'm sorry! :-(
> 
> What dpranke@ asks for sounds great though. That would help protect against
> accidental changes like mine.

Yes, of course that sounds like a good idea. Could someone please file a bug
about it? Any help implementing this would be greatly appreciated.