Issue 2574523002: Revert "Make list_files.py and list_dart_files.py return absolute paths"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2574523002: Revert "Make list_files.py and list_dart_files.py return absolute paths" (Closed)

Created:
4 years ago by zra

Modified:
4 years ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Make list_files.py and list_dart_files.py return absolute paths" This reverts commit a858542c89adb85b901d55457bd74300bc083eab. mac gyp build fails. Committed: https://github.com/dart-lang/sdk/commit/b873e2b8e3098e01ba3c5e4dc50b17cf4e88b881

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -13 lines)			Patch
M	BUILD.gn	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/BUILD.gn	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/list_dart_files.py	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	tools/list_files.py	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	utils/create_timestamp.gni	View	2 chunks	+10 lines, -1 line	0 comments	Download

Total messages: 4 (2 generated)

zra

4 years ago (2016-12-12 21:14:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b873e2b8e3098e01ba3c5e4dc50b17cf4e88b881 (presubmit successful).